chrome/browser/sync/glue/typed_url_change_processor.cc - Issue 1139883007: Sync: ParentChildIndex fix for out of order deletion of entries by PurgeEntriesWithTypeIn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/typed_url_change_processor.cc

Issue 1139883007: Sync: ParentChildIndex fix for out of order deletion of entries by PurgeEntriesWithTypeIn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/glue/typed_url_change_processor.cc

diff --git a/chrome/browser/sync/glue/typed_url_change_processor.cc b/chrome/browser/sync/glue/typed_url_change_processor.cc

index 49f07fe102cdaaeed08adc1994c219294f4a4f06..b00cd3d190015d05b8ea078dd7dbfe1eb31e8998 100644

--- a/chrome/browser/sync/glue/typed_url_change_processor.cc

+++ b/chrome/browser/sync/glue/typed_url_change_processor.cc

@@ -267,8 +267,6 @@ void TypedUrlChangeProcessor::ApplyChangesFromSyncModel(

return;

}

- // Check that the changed node is a child of the typed_urls folder.

- DCHECK(typed_url_root.GetId() == sync_node.GetParentId());

DCHECK(syncer::TYPED_URLS == sync_node.GetModelType());

const sync_pb::TypedUrlSpecifics& typed_url(

« no previous file with comments | « no previous file | sync/syncable/parent_child_index.cc » ('j') | no next file with comments »