Set pointers in internal fields directly instead of wrapping them

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h" 
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
@@ skipping 247 matching lines @@
 
 
                 if(pObjDef->objType == JS_DYNAMIC)
                 {
                         //Document is set as global object, need to construct it first.
                         if(ws.Equal(L"Document"))
                         {
 
                                 CJS_PrivateData* pPrivateData = new CJS_PrivateData;
                                 pPrivateData->ObjDefID = i;
-                                v8::Handle<v8::External> ptr = v8::External::New(isolate, pPrivateData);
 
-                                v8Context->Global()->GetPrototype()->ToObject()->SetInternalField(0, ptr); 
+                                v8Context->Global()->GetPrototype()->ToObject()->SetAlignedPointerInInternalField(0, pPrivateData); 
 
                                 if(pObjDef->m_pConstructor)
                                         pObjDef->m_pConstructor(context, v8Context->Global()->GetPrototype()->ToObject(), v8Context->Global()->GetPrototype()->ToObject());
                         }
                 }
                 else
                 {
                         v8::Handle<v8::Object> obj = JS_NewFxDynamicObj(pJSRuntime, context, i);
                         v8Context->Global()->Set(objName, obj);
                         pObjDef->m_StaticObj.Reset(isolate, obj);
@@ skipping 94 matching lines @@
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return v8::Handle<v8::Object>();
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
 
         v8::Local<v8::Context> context = isolate->GetCurrentContext();
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         v8::Local<v8::Object> obj = objTemp->NewInstance();
 
         CJS_PrivateData* pPrivateData = new CJS_PrivateData;
         pPrivateData->ObjDefID = nObjDefnID;
 
-        v8::Handle<v8::External> ptr = v8::External::New(isolate, pPrivateData);
-        obj->SetInternalField(0, ptr);
+        obj->SetAlignedPointerInInternalField(0, pPrivateData);
         if(pObjDef->m_pConstructor)
                 pObjDef->m_pConstructor(pJSContext, obj, context->Global()->GetPrototype()->ToObject());
 
         return obj;
 }
 
 v8::Handle<v8::Object> JS_GetStaticObj(IJS_Runtime* pJSRuntime, int nObjDefnID)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
@@ skipping 20 matching lines @@
         CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(0);
         if(!pArray) return v8::Handle<v8::Object>();
 
         v8::Local<v8::Context> context = isolate->GetCurrentContext();
         return context->Global()->GetPrototype()->ToObject();
 }
 
 int     JS_GetObjDefnID(v8::Handle<v8::Object> pObj)
 {
         if(pObj.IsEmpty() || !pObj->InternalFieldCount()) return -1;
-        v8::Handle<v8::External> field = v8::Handle<v8::External>::Cast(pObj->GetInternalField(0));
-        CJS_PrivateData* pPrivateData = (CJS_PrivateData*)field->Value();
+        CJS_PrivateData* pPrivateData = (CJS_PrivateData*)pObj->GetAlignedPointerFromInternalField(0);
         if(pPrivateData)
                 return pPrivateData->ObjDefID;
         return -1;
 }
 
 IJS_Runtime* JS_GetRuntime(v8::Handle<v8::Object> pObj)
 {
         if(pObj.IsEmpty()) return NULL;
         v8::Local<v8::Context> context = pObj->CreationContext();
         if(context.IsEmpty()) return NULL;
@@ skipping 62 matching lines @@
 }
 
 void* JS_GetPrivate(v8::Handle<v8::Object> pObj)
 {
         return JS_GetPrivate(NULL,pObj);
 }
 
 void JS_SetPrivate(IJS_Runtime* pJSRuntime, v8::Handle<v8::Object> pObj, void* p)
 {
         if(pObj.IsEmpty() || !pObj->InternalFieldCount()) return;
-        v8::Handle<v8::External> ptr = v8::Handle<v8::External>::Cast(pObj->GetInternalField(0));
-        CJS_PrivateData* pPrivateData  = (CJS_PrivateData*)ptr->Value();
+        CJS_PrivateData* pPrivateData  = (CJS_PrivateData*)pObj->GetAlignedPointerFromInternalField(0);
         if(!pPrivateData) return;
         pPrivateData->pPrivate = p;
 }
 
 void* JS_GetPrivate(IJS_Runtime* pJSRuntime, v8::Handle<v8::Object> pObj)
 {
         if(pObj.IsEmpty()) return NULL;
-        v8::Local<v8::Value> value;
+        CJS_PrivateData* pPrivateData  = NULL;
         if(pObj->InternalFieldCount())
-                value = pObj->GetInternalField(0); 
+                pPrivateData = (CJS_PrivateData*)pObj->GetAlignedPointerFromInternalField(0);
         else
         {
                 //It could be a global proxy object.
                 v8::Local<v8::Value> v = pObj->GetPrototype();
                 if(v->IsObject())
-                        value = v->ToObject()->GetInternalField(0);
+                        pPrivateData = (CJS_PrivateData*)v->ToObject()->GetAlignedPointerFromInternalField(0);
         }
-        if(value.IsEmpty() || value->IsUndefined()) return NULL;
-        v8::Handle<v8::External> ptr = v8::Handle<v8::External>::Cast(value);
-        CJS_PrivateData* pPrivateData  = (CJS_PrivateData*)ptr->Value();
         if(!pPrivateData) return NULL;
         return pPrivateData->pPrivate;
 }
 
 void JS_FreePrivate(v8::Handle<v8::Object> pObj)
 {
         if(pObj.IsEmpty() || !pObj->InternalFieldCount()) return;
-        v8::Handle<v8::External> ptr = v8::Handle<v8::External>::Cast(pObj->GetInternalField(0));
-        delete (CJS_PrivateData*)ptr->Value();
-        v8::Local<v8::Context> context = pObj->CreationContext();
-
-        pObj->SetInternalField(0, v8::External::New(context->GetIsolate(), NULL));
+        delete (CJS_PrivateData*)pObj->GetAlignedPointerFromInternalField(0);
+        pObj->SetAlignedPointerInInternalField(0, NULL);
 }
 
 
 v8::Handle<v8::Value> JS_GetObjectValue(v8::Handle<v8::Object> pObj)
 {
         return pObj;
 }
 
 v8::Handle<v8::String> WSToJSString(IJS_Runtime* pJSRuntime, const wchar_t* PropertyName, int Len = -1)
 {
@@ skipping 485 matching lines @@
 {
         return d != d;
 }
 
 double JS_LocalTime(double d)
 {
         return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 //JavaScript time implement End.