HttpServerProperties - Track UpdatePrefs callers. In offical builds, on

net/http/http_server_properties_manager.h

Index: net/http/http_server_properties_manager.h
diff --git a/net/http/http_server_properties_manager.h b/net/http/http_server_properties_manager.h
index 406905df2161dde94985e42c0debffd2577c32da..0add777fb778d55021bfc6aaf31ab6b5058f782d 100644
--- a/net/http/http_server_properties_manager.h
+++ b/net/http/http_server_properties_manager.h
@@ -51,6 +51,25 @@ namespace net {
 // and grab a WeakPtr.
 class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
  public:
+  // The location where ScheduleUpdatePrefsOnNetworkThread was called.
+  enum Location {

[mmenke, 2015/05/12 17:38:52]

Suggest putting these in protected section and then exposing them in the test
subclass, like you do for ScheduleUpdatePrefsOnNetworkThread.  Makes it clearer
what the public API is.

[ramant (doing other things), 2015/05/12 17:57:17]

Done.

+    SUPPORTS_SPDY = 0,
+    HTTP_11_REQUIRED = 1,
+    SET_ALTERNATIVE_SERVICE = 2,
+    MARK_ALTERNATIVE_SERVICE_BROKEN = 3,
+    MARK_ALTERNATIVE_SERVICE_RECENTLY_BROKEN = 4,
+    CONFIRM_ALTERNATIVE_SERVICE = 5,
+    CLEAR_ALTERNATIVE_SERVICE = 6,
+    SET_SPDY_SETTING = 7,
+    CLEAR_SPDY_SETTINGS = 8,
+    CLEAR_ALL_SPDY_SETTINGS = 9,
+    SET_SUPPORTS_QUIC = 10,
+    SET_SERVER_NETWORK_STATS = 11,
+    DETECTED_CORRUPTED_PREFS = 12,
+    UNIT_TESTS = 13,

[mmenke, 2015/05/12 17:38:52]

Don't think this is really needed - can just use a random one.

[ramant (doing other things), 2015/05/12 17:57:17]

Done.

+    NUM_LOCATIONS = 14,
+  };
+
   // Create an instance of the HttpServerPropertiesManager. The lifetime of the
   // PrefService objects must be longer than that of the
   // HttpServerPropertiesManager object. Must be constructed on the Pref thread.
@@ -154,7 +173,8 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
   // These are used to delay updating the preferences when cached data in
   // |http_server_properties_impl_| is changing, and execute only one update per
   // simultaneous spdy_servers or spdy_settings or alternative_service changes.
-  void ScheduleUpdatePrefsOnNetworkThread();
+  // |location| specifies where this method is called from.
+  void ScheduleUpdatePrefsOnNetworkThread(Location location);
 
   // Starts the timers to update the prefs from cache. This are overridden in
   // tests to prevent the delay.