HttpServerProperties - Track UpdatePrefs callers. In offical builds, on

net/http/http_server_properties_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_SERVER_PROPERTIES_MANAGER_H_
 #define NET_HTTP_HTTP_SERVER_PROPERTIES_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 33 matching lines @@
 // release the prefs listeners on the pref thread.
 //
 // Class requires that update tasks from the Pref thread can post safely to the
 // network thread, so the destruction order must guarantee that if |this|
 // exists in pref thread, then a potential destruction on network thread will
 // come after any task posted to network thread from that method on pref thread.
 // This is used to go through network thread before the actual update starts,
 // and grab a WeakPtr.
 class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
  public:
+  // The location where ScheduleUpdatePrefsOnNetworkThread was called.
+  enum Location {

[mmenke, 2015/05/12 17:38:52]

Suggest putting these in protected section and then exposing them in the test
subclass, like you do for ScheduleUpdatePrefsOnNetworkThread.  Makes it clearer
what the public API is.

[ramant (doing other things), 2015/05/12 17:57:17]

Done.

+    SUPPORTS_SPDY = 0,
+    HTTP_11_REQUIRED = 1,
+    SET_ALTERNATIVE_SERVICE = 2,
+    MARK_ALTERNATIVE_SERVICE_BROKEN = 3,
+    MARK_ALTERNATIVE_SERVICE_RECENTLY_BROKEN = 4,
+    CONFIRM_ALTERNATIVE_SERVICE = 5,
+    CLEAR_ALTERNATIVE_SERVICE = 6,
+    SET_SPDY_SETTING = 7,
+    CLEAR_SPDY_SETTINGS = 8,
+    CLEAR_ALL_SPDY_SETTINGS = 9,
+    SET_SUPPORTS_QUIC = 10,
+    SET_SERVER_NETWORK_STATS = 11,
+    DETECTED_CORRUPTED_PREFS = 12,
+    UNIT_TESTS = 13,

[mmenke, 2015/05/12 17:38:52]

Don't think this is really needed - can just use a random one.

[ramant (doing other things), 2015/05/12 17:57:17]

Done.

+    NUM_LOCATIONS = 14,
+  };
+
   // Create an instance of the HttpServerPropertiesManager. The lifetime of the
   // PrefService objects must be longer than that of the
   // HttpServerPropertiesManager object. Must be constructed on the Pref thread.
   HttpServerPropertiesManager(
       PrefService* pref_service,
       const char* pref_path,
       scoped_refptr<base::SequencedTaskRunner> network_task_runner);
   ~HttpServerPropertiesManager() override;
 
   // Initialize on Network thread.
@@ skipping 83 matching lines @@
       std::vector<std::string>* spdy_servers,
       SpdySettingsMap* spdy_settings_map,
       AlternativeServiceMap* alternative_service_map,
       IPAddressNumber* last_quic_address,
       ServerNetworkStatsMap* server_network_stats_map,
       bool detected_corrupted_prefs);
 
   // These are used to delay updating the preferences when cached data in
   // |http_server_properties_impl_| is changing, and execute only one update per
   // simultaneous spdy_servers or spdy_settings or alternative_service changes.
-  void ScheduleUpdatePrefsOnNetworkThread();
+  // |location| specifies where this method is called from.
+  void ScheduleUpdatePrefsOnNetworkThread(Location location);
 
   // Starts the timers to update the prefs from cache. This are overridden in
   // tests to prevent the delay.
   virtual void StartPrefsUpdateTimerOnNetworkThread(base::TimeDelta delay);
 
   // Update prefs::kHttpServerProperties in preferences with the cached data
   // from |http_server_properties_impl_|. This gets the data on network thread
   // and posts a task (UpdatePrefsOnPrefThread) to update preferences on pref
   // thread.
   void UpdatePrefsFromCacheOnNetworkThread();
@@ skipping 81 matching lines @@
   // Used to get |weak_ptr_| to self on the network thread.
   scoped_ptr<base::WeakPtrFactory<HttpServerPropertiesManager> >
       network_weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpServerPropertiesManager);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_SERVER_PROPERTIES_MANAGER_H_