Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: tools/telemetry/telemetry/page/action_runner.py

Issue 1139743005: [Telemetry] Kill action_runner.NavigateToPage API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/action_runner.py
diff --git a/tools/telemetry/telemetry/page/action_runner.py b/tools/telemetry/telemetry/page/action_runner.py
index a362555dfee9425ec63073b70cbb112580732e68..a56336690b420aacb9471c48a7f6b3c9e3b09115 100644
--- a/tools/telemetry/telemetry/page/action_runner.py
+++ b/tools/telemetry/telemetry/page/action_runner.py
@@ -97,23 +97,6 @@ class ActionRunner(object):
"""
return self.CreateInteraction('Gesture_' + label, repeatable)
- def NavigateToPage(self, page, timeout_in_seconds=60):
- """Navigates to the given page.
-
- TODO(ariblue): Remove this sometime in/after Feb 2015. NavigateToPage has
- been deprecated since action_runner will support arbitrary user stories
- and web contents.
- """
- logging.warn('NavigateToPage is deprecated. Please use Navigate instead.')
- if page.is_file:
- target_side_url = self._tab.browser.http_server.UrlOf(page.file_path_url)
- else:
- target_side_url = page.url
- self._RunAction(NavigateAction(
- url=target_side_url,
- script_to_evaluate_on_commit=page.script_to_evaluate_on_commit,
- timeout_in_seconds=timeout_in_seconds))
-
def Navigate(self, url, script_to_evaluate_on_commit=None,
timeout_in_seconds=60):
"""Navigates to url.
« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698