tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py - Issue 1139743005: [Telemetry] Kill action_runner.NavigateToPage API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

Issue 1139743005: [Telemetry] Kill action_runner.NavigateToPage API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

index d6af6b16a0c44d1f4a414a3825162b8dcee98a2a..ef3dfbb3c417b2de8f909d7330046758d02e5038 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

@@ -18,7 +18,7 @@ class SafebrowsingPage(page_module.Page):

self.archive_data_file = '../data/chrome_proxy_safebrowsing.json'

def RunNavigateSteps(self, action_runner):

- action_runner.NavigateToPage(self, timeout_in_seconds=5)

+ action_runner.Navigate(self.url, timeout_in_seconds=5)

class SafebrowsingPageSet(page_set_module.PageSet):

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/action_runner.py » ('j') | no next file with comments »