Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1139673008: cc: Make IsReadyToDraw/NeedsRaster usage consistent. (Closed)

Created:
5 years, 7 months ago by vmpstr
Modified:
5 years, 7 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make IsReadyToDraw/NeedsRaster usage consistent. There are two ways of accessing IsReadyToDraw and NeedsRaster. One is via tile->IsReadyToDraw(), the other is via tile->draw_info().IsReadyToDraw(). The first one is actually does the same thing as the second one. This patch removes the shortcut and makes all uses of this functionality consistent. R=enne Committed: https://crrev.com/3619e48edfdfad6683c55992103d89897108783f Cr-Commit-Position: refs/heads/master@{#329996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -49 lines) Patch
M cc/layers/picture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile.h View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/resources/tile.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M cc/resources/tile_draw_info.h View 1 chunk +23 lines, -1 line 0 comments Download
M cc/resources/tile_draw_info.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M cc/resources/tile_manager.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/tiling_set_eviction_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tiling_set_raster_queue_all.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tiling_set_raster_queue_required.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Please take a look.
5 years, 7 months ago (2015-05-14 20:49:54 UTC) #1
enne (OOO)
lgtm
5 years, 7 months ago (2015-05-14 23:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139673008/1
5 years, 7 months ago (2015-05-14 23:46:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 00:39:59 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:40:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3619e48edfdfad6683c55992103d89897108783f
Cr-Commit-Position: refs/heads/master@{#329996}

Powered by Google App Engine
This is Rietveld 408576698