mandoline/ui/browser/browser.cc - Issue 1139673003: Make Mandoline shut down cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/browser/browser.cc

Issue 1139673003: Make Mandoline shut down cleanly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash in surfaces if surfaceimpl outlives the app, and a double delete in browser Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mandoline/ui/browser/browser.cc

diff --git a/mandoline/ui/browser/browser.cc b/mandoline/ui/browser/browser.cc

index 202c76cae580b4859ec24bddaa3b2811b093a79b..4697e40afc2370071f55ee999a83d956ec88e7dc 100644

--- a/mandoline/ui/browser/browser.cc

+++ b/mandoline/ui/browser/browser.cc

@@ -26,6 +26,10 @@ Browser::Browser()

}

Browser::~Browser() {

+ // Destruct ui_ manually while |this| is alive and reset the pointer first.

+ // This is to avoid a double delete when OnViewManagerDisconnected gets

+ // called.

+ delete ui_.release();

}

void Browser::ReplaceContentWithURL(const mojo::String& url) {