mandoline/services/core_services/core_services_application_delegate.cc - Issue 1139673003: Make Mandoline shut down cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/services/core_services/core_services_application_delegate.cc

Issue 1139673003: Make Mandoline shut down cleanly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash in surfaces if surfaceimpl outlives the app, and a double delete in browser Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/native_viewport/main.cc ('K') | « components/window_manager/window_manager_app.cc ('k') | mandoline/ui/browser/browser.cc » ('j') | mojo/application/app_lifetime_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mandoline/services/core_services/core_services_application_delegate.cc

diff --git a/mandoline/services/core_services/core_services_application_delegate.cc b/mandoline/services/core_services/core_services_application_delegate.cc

index 0cf941bc42928fc62d11cd7b63757904aa7d3515..751407f2e8f9eee78008141b6ae88c22091be9bb 100644

--- a/mandoline/services/core_services/core_services_application_delegate.cc

+++ b/mandoline/services/core_services/core_services_application_delegate.cc

@@ -70,6 +70,8 @@ class ApplicationThread : public base::Thread {

}

void RequestQuit() {

+ if (!IsRunning())

+ return;

task_runner()->PostTask(

FROM_HERE,

base::Bind(&ApplicationThread::ShutdownCleanly,

« components/native_viewport/main.cc ('K') | « components/window_manager/window_manager_app.cc ('k') | mandoline/ui/browser/browser.cc » ('j') | mojo/application/app_lifetime_helper.h » ('J')