Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1139663004: Clear focus before committing a time value in the time related pickers (Closed)

Created:
5 years, 7 months ago by Miguel Garcia
Modified:
5 years, 7 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear focus before committing a time value in the time related pickers Values entered with the on-screen keyboard are only accepted once the focus has been cleared from the element. BUG=457116 Committed: https://crrev.com/483c323993676043e1815e85c31470ebefcb4c32 Cr-Commit-Position: refs/heads/master@{#330111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java View 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java View 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Miguel Garcia
If you happen to like the change, can I ask you to click the CQ ...
5 years, 7 months ago (2015-05-15 14:46:12 UTC) #2
Miguel Garcia
On 2015/05/15 14:46:12, Miguel Garcia wrote: > If you happen to like the change, can ...
5 years, 7 months ago (2015-05-15 15:40:37 UTC) #3
newt (away)
lgtm
5 years, 7 months ago (2015-05-15 16:03:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139663004/1
5 years, 7 months ago (2015-05-15 16:04:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 16:56:04 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:58:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/483c323993676043e1815e85c31470ebefcb4c32
Cr-Commit-Position: refs/heads/master@{#330111}

Powered by Google App Engine
This is Rietveld 408576698