Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java

Issue 1139663004: Clear focus before committing a time value in the time related pickers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
diff --git a/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java b/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
index f8647ec24d2d9e0811b1cea542154f6bd8bbf8fb..43cee0e852e09c0891fb5020e72441fabe713cb1 100644
--- a/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
+++ b/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
@@ -247,12 +247,12 @@ public class MultiFieldTimePickerDialog
}
private void notifyDateSet() {
- int hour = mHourSpinner.getValue();
- int minute = mMinuteSpinner.getValue();
- int sec = mSecSpinner.getValue();
- int milli = mMilliSpinner.getValue() * mStep + mBaseMilli;
+ int hour = getPickerValue(mHourSpinner);
+ int minute = getPickerValue(mMinuteSpinner);
+ int sec = getPickerValue(mSecSpinner);
+ int milli = getPickerValue(mMilliSpinner) * mStep + mBaseMilli;
if (!mIs24hourFormat) {
- int ampm = mAmPmSpinner.getValue();
+ int ampm = getPickerValue(mAmPmSpinner);
if (hour == 12) {
hour = 0;
}
@@ -261,6 +261,15 @@ public class MultiFieldTimePickerDialog
mListener.onTimeSet(hour, minute, sec, milli);
}
+ /**
+ * Clear focus before retrieving so that values inserted with
+ * keyboard are taken into account.
+ */
+ private int getPickerValue(NumberPicker picker) {
+ picker.clearFocus();
+ return picker.getValue();
+ }
+
private static class NumberFormatter implements NumberPicker.Formatter {
private final String mFormat;
« no previous file with comments | « ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698