Make chrome.instanceID only available on dev and canary.

Make chrome.instanceID only available on dev and canary.

Also, we don't need field trial for dev and canary.

BUG=477084
TEST=new tests

Committed: https://crrev.com/df27958327fd89c3338e208b5501f9d464e8dac2
Cr-Commit-Position: refs/heads/master@{#330273}

[jianli, 2015-05-15 22:51:36]

jianli@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2015-05-15 22:53:51]

On 2015/05/15 22:51:37, jianli wrote:

LGTM

[jianli, 2015-05-15 23:04:41]

jianli@chromium.org changed reviewers:
+ kalman@chromium.org

[jianli, 2015-05-15 23:04:42]

Kalman, could you please review it?

[not at google - send to devlin, 2015-05-15 23:07:26]

lgtm

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/instance_id/instance_id_apitest.cc (right):

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/instance_id/instance_id_apitest.cc:53:
chrome::VersionInfo::CHANNEL_CANARY);
use DEV, and have the ScopedCurrentChannel be a member variable of
InstanceIDApiTest rather than writing it everywhere.

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/services...
File chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
(right):

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/services...
chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc:27: }
you could also grab the API Feature and check against that. I can't remember off
the top of my head exactly, but it's something like

extensions::FeatureProvider::GetAPIFeature("gcm").IsAvailable().is_avaialble()

[jianli, 2015-05-15 23:11:37]

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/instance_id/instance_id_apitest.cc (right):

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/instance_id/instance_id_apitest.cc:53:
chrome::VersionInfo::CHANNEL_CANARY);
On 2015/05/15 23:07:26, kalman wrote:
> use DEV, and have the ScopedCurrentChannel be a member variable of
> InstanceIDApiTest rather than writing it everywhere.

The following tests check against DEV. I just want to have 1 test to check on
CANARY. I will change this to DEV. Also the reason for not defining a member
variable is that I need to set it to BETA or STABLE negative testing and I do
not want to introduce another test class if I use the member variable.

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/services...
File chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
(right):

https://codereview.chromium.org/1139633005/diff/20001/chrome/browser/services...
chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc:27: }
On 2015/05/15 23:07:26, kalman wrote:
> you could also grab the API Feature and check against that. I can't remember
off
> the top of my head exactly, but it's something like
> 
> extensions::FeatureProvider::GetAPIFeature("gcm").IsAvailable().is_avaialble()

InstanceIDProfileService might be used by others, not just extensions. This is
why I do not do any API check here.

[jianli, 2015-05-15 23:56:26]

The CQ bit was checked by jianli@chromium.org

[jianli, 2015-05-15 23:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
fgorski@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1139633005/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2015-05-15 23:57:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139633005/40001

[commit-bot: I haz the power, 2015-05-16 03:12:34]

Committed patchset #3 (id:40001)

[Nico, 2015-05-17 01:19:25]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-05-17 01:19:27]

https://codereview.chromium.org/1139633005/diff/40001/chrome/browser/services...
File chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
(right):

https://codereview.chromium.org/1139633005/diff/40001/chrome/browser/services...
chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc:25:
channel == chrome::VersionInfo::CHANNEL_STABLE) {
What's the motivation for this? We try to not make features available based on
the channel. Can you use a command-line flag (and optionally an about:flags
entry) instead?

[Nico, 2015-05-17 03:42:54]

…in addition that we try to not make features dependent on the channel, it looks
like the api tests for this now fail on builders running browser_tests in
official builds:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/...

[commit-bot: I haz the power, 2015-05-18 11:31:12]

Patchset 3 (id:??) landed as
https://crrev.com/df27958327fd89c3338e208b5501f9d464e8dac2
Cr-Commit-Position: refs/heads/master@{#330273}