Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3964)

Unified Diff: chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc

Issue 1139633005: Make chrome.instanceID only available on dev and canary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
diff --git a/chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc b/chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
index 47a6f3a06ca398a748512b1369e86e658217662e..dc80f364d99561afc9a4df06b7da5ba6e621ccf3 100644
--- a/chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
+++ b/chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc
@@ -19,10 +19,12 @@ bool InstanceIDProfileService::IsInstanceIDEnabled(Profile* profile) {
if (!gcm::GCMProfileService::IsGCMEnabled(profile))
return false;
- // Enabled for trunk build.
+ // Enabled only for trunk/canary/dev builds.
chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
- if (channel == chrome::VersionInfo::CHANNEL_UNKNOWN)
- return true;
+ if (channel == chrome::VersionInfo::CHANNEL_BETA ||
+ channel == chrome::VersionInfo::CHANNEL_STABLE) {
Nico 2015/05/17 01:19:26 What's the motivation for this? We try to not make
+ return false;
+ }
return InstanceIDDriver::IsInstanceIDEnabled();
}
« no previous file with comments | « chrome/browser/extensions/api/instance_id/instance_id_apitest.cc ('k') | chrome/common/extensions/api/_api_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698