Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1139273002: Set an explicit object type=text/plain in reload-subframe.pl. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
CC:
blink-reviews, eroman
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set an explicit object type=text/plain in reload-subframe.pl. Otherwise, for the navigation/reload-subframe-object.html test on Linux, the browser would return application/x-perl as the mime type, which causes the test to fail. I worked around this 6 years in http://crrev.com/16233 but it's time to remove the hack. The Chromium side hack removal is: https://codereview.chromium.org/1131263011 BUG=488585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/http/tests/navigation/resources/reload-subframe.pl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Lei Zhang
5 years, 7 months ago (2015-05-16 01:02:12 UTC) #2
eroman
LGTM!
5 years, 7 months ago (2015-05-16 01:11:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139273002/1
5 years, 7 months ago (2015-05-16 01:14:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-16 03:41:10 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-19 11:03:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139273002/1
5 years, 7 months ago (2015-05-19 17:05:17 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:37:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195538

Powered by Google App Engine
This is Rietveld 408576698