Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1131263011: Remove an old TODO in net/base. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an old TODO in net/base. This was added in http://crrev.com/16233, but will no longer be needed once https://codereview.chromium.org/1139273002/ fixes the test. BUG=488585 Committed: https://crrev.com/8f279b4c8ad2374ba272f4c3a3446495fbfabc86 Cr-Commit-Position: refs/heads/master@{#330894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M net/base/platform_mime_util_linux.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Lei Zhang
5 years, 7 months ago (2015-05-16 01:02:16 UTC) #2
eroman
LGTM, thanks for doing this! BTW in the description, change "http://crre.com/16233" --> "http://crrev.com/16233"
5 years, 7 months ago (2015-05-16 01:13:53 UTC) #3
Lei Zhang
On 2015/05/16 01:13:53, eroman (sick slow) wrote: > BTW in the description, change "http://crre.com/16233" --> ...
5 years, 7 months ago (2015-05-16 01:16:01 UTC) #4
eroman
lgtm
5 years, 7 months ago (2015-05-17 22:45:28 UTC) #5
eroman
Note that the Blink side has rolled, so you can probably commit this unless there ...
5 years, 7 months ago (2015-05-20 23:01:22 UTC) #6
Lei Zhang
On 2015/05/20 23:01:22, eroman (sick slow) wrote: > Note that the Blink side has rolled, ...
5 years, 7 months ago (2015-05-20 23:11:54 UTC) #7
Lei Zhang
On 2015/05/20 23:11:54, Lei Zhang wrote: > On 2015/05/20 23:01:22, eroman (sick slow) wrote: > ...
5 years, 7 months ago (2015-05-21 01:05:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131263011/1
5 years, 7 months ago (2015-05-21 01:07:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 04:42:42 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:43:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f279b4c8ad2374ba272f4c3a3446495fbfabc86
Cr-Commit-Position: refs/heads/master@{#330894}

Powered by Google App Engine
This is Rietveld 408576698