Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1139123007: [Effen] remove the last traces of the 'display' property from the effen component library. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] remove the last traces of the 'display' property from the effen component library. Previously, the fn "Text" class rendered as a single block of text. Now, there's a "Paragraph" class that contains "TextFragment"s, and "Text" is just a component that places a single TextFragment into a single Paragraph. This allows other components, notably the Input component, to build more complicated paragraphs of styled text, without using 'display'. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0ceb8b1c249a2ea425fff4592e46127a23376a04

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -46 lines) Patch
M sky/framework/components/input.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M sky/framework/editing/editable_text.dart View 3 chunks +7 lines, -13 lines 0 comments Download
M sky/framework/fn.dart View 11 chunks +49 lines, -24 lines 0 comments Download
M sky/framework/layout.dart View 2 chunks +16 lines, -4 lines 0 comments Download
M sky/tests/framework/basic.sky View 1 1 chunk +3 lines, -1 line 0 comments Download
M sky/tests/framework/basic-expected.txt View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Hixie
Note that I need to update the basic.sky test expectations file before I commit this. ...
5 years, 7 months ago (2015-05-14 21:47:47 UTC) #1
eseidel
lgtm
5 years, 7 months ago (2015-05-14 22:20:16 UTC) #3
Hixie
5 years, 7 months ago (2015-05-14 22:21:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0ceb8b1c249a2ea425fff4592e46127a23376a04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698