Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: sky/framework/components/input.dart

Issue 1139123007: [Effen] remove the last traces of the 'display' property from the effen component library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/framework/editing/editable_text.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/input.dart
diff --git a/sky/framework/components/input.dart b/sky/framework/components/input.dart
index 8ed2f0d37c69fefcda057a32a7c310ece78ec8b8..111d582a3300e27ece4a7009384ad134929fdc02 100644
--- a/sky/framework/components/input.dart
+++ b/sky/framework/components/input.dart
@@ -6,6 +6,7 @@ import '../editing/editable_string.dart';
import '../editing/editable_text.dart';
import '../editing/keyboard.dart';
import '../fn.dart';
+import '../layout.dart';
import '../theme/colors.dart';
import '../theme/typography.dart' as typography;
import 'dart:sky' as sky;
@@ -14,7 +15,6 @@ typedef void ValueChanged(value);
class Input extends Component {
static final Style _style = new Style('''
- display: paragraph;
transform: translateX(0);
margin: 8px;
padding: 8px;
@@ -84,7 +84,8 @@ class Input extends Component {
children.add(new EditableText(value: _editableValue, focused: focused));
return new EventListenerNode(
- new Container(
+ new FlexContainer(
+ direction: FlexDirection.Column,
style: _style,
inlineStyle: focused ? _focusedInlineStyle : null,
children: children
« no previous file with comments | « no previous file | sky/framework/editing/editable_text.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698