Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1139053005: Add ServeLocalDirectory to the shell abstraction. (Closed)

Created:
5 years, 7 months ago by ppi
Modified:
5 years, 7 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add ServeLocalDirectory to the shell abstraction. This patch adds a ServeLocalDirectory method to the shell abstraction, allowing to make content of any directory on the host machine available to the shell under a url. On both platforms it means serving the content using a local http server, on Android it additionally involves a reverse port forwarding set up for the device. Note that the specific implementation of the server logic is still up in the air at this point - this just introduces an API in front of what we have today. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eec33f45f47f460fd148fdbdb5ca2d5ea3b00dde

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 3 chunks +24 lines, -13 lines 0 comments Download
M mojo/devtools/common/devtoolslib/http_server.py View 1 1 chunk +9 lines, -5 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Ben, ptal.
5 years, 7 months ago (2015-05-19 13:20:02 UTC) #2
qsr
LGTM with nit. https://codereview.chromium.org/1139053005/diff/1/mojo/devtools/common/devtoolslib/android_shell.py File mojo/devtools/common/devtoolslib/android_shell.py (right): https://codereview.chromium.org/1139053005/diff/1/mojo/devtools/common/devtoolslib/android_shell.py#newcode238 mojo/devtools/common/devtoolslib/android_shell.py:238: return self._StartHttpServerForDirectory(local_dir_path, port) You are just ...
5 years, 7 months ago (2015-05-19 13:55:42 UTC) #3
ppi
Thanks! https://codereview.chromium.org/1139053005/diff/1/mojo/devtools/common/devtoolslib/android_shell.py File mojo/devtools/common/devtoolslib/android_shell.py (right): https://codereview.chromium.org/1139053005/diff/1/mojo/devtools/common/devtoolslib/android_shell.py#newcode238 mojo/devtools/common/devtoolslib/android_shell.py:238: return self._StartHttpServerForDirectory(local_dir_path, port) On 2015/05/19 13:55:42, qsr wrote: ...
5 years, 7 months ago (2015-05-19 14:22:48 UTC) #4
ppi
5 years, 7 months ago (2015-05-19 14:29:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eec33f45f47f460fd148fdbdb5ca2d5ea3b00dde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698