Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: mojo/devtools/common/devtoolslib/linux_shell.py

Issue 1139053005: Add ServeLocalDirectory to the shell abstraction. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/linux_shell.py
diff --git a/mojo/devtools/common/devtoolslib/linux_shell.py b/mojo/devtools/common/devtoolslib/linux_shell.py
index 30ab4e98b4c0fa8be358fdd3d1e2f423cbdf2252..4b3d98a4cd2ef636807a1620f8db2db4fb869dd4 100644
--- a/mojo/devtools/common/devtoolslib/linux_shell.py
+++ b/mojo/devtools/common/devtoolslib/linux_shell.py
@@ -5,6 +5,7 @@
import subprocess
from devtoolslib.shell import Shell
+from devtoolslib import http_server
class LinuxShell(Shell):
@@ -20,6 +21,22 @@ class LinuxShell(Shell):
self.executable_path = executable_path
self.command_prefix = command_prefix if command_prefix else []
+ def ServeLocalDirectory(self, local_dir_path, port=0):
+ """Serves the content of the local (host) directory, making it available to
+ the shell under the url returned by the function.
+
+ The server will run on a separate thread until the program terminates. The
+ call returns immediately.
+
+ Args:
+ local_dir_path: path to the directory to be served
+ port: port at which the server will be available to the shell
+
+ Returns:
+ The url that the shell can use to access the content of |local_dir_path|.
+ """
+ return 'http://%s:%d/' % http_server.StartHttpServer(local_dir_path, port)
+
def Run(self, arguments):
"""Runs the shell with given arguments until shell exits, passing the stdout
mingled with stderr produced by the shell onto the stdout.
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698