Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: net/http/http_network_transaction.cc

Issue 1139013002: Completely remove SSLv3 support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 981fcb6abb003efef8362d272967df28d96309e0..c094bdbbae1c626d01774e9d9be5204bdd340d4c 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -1435,8 +1435,8 @@ void HttpNetworkTransaction::ResetStateForAuthRestart() {
void HttpNetworkTransaction::RecordSSLFallbackMetrics() {
// Note: these values are used in histograms, so new values must be appended.
enum FallbackVersion {
- FALLBACK_NONE = 0, // SSL version fallback did not occur.
- FALLBACK_SSL3 = 1, // Fell back to SSL 3.0.
+ FALLBACK_NONE = 0, // SSL version fallback did not occur.
+ // Obsolete: FALLBACK_SSL3 = 1,
FALLBACK_TLS1 = 2, // Fell back to TLS 1.0.
FALLBACK_TLS1_1 = 3, // Fell back to TLS 1.1.
FALLBACK_MAX,
@@ -1445,9 +1445,6 @@ void HttpNetworkTransaction::RecordSSLFallbackMetrics() {
FallbackVersion fallback = FALLBACK_NONE;
if (server_ssl_config_.version_fallback) {
switch (server_ssl_config_.version_max) {
- case SSL_PROTOCOL_VERSION_SSL3:
- fallback = FALLBACK_SSL3;
- break;
case SSL_PROTOCOL_VERSION_TLS1:
fallback = FALLBACK_TLS1;
break;

Powered by Google App Engine
This is Rietveld 408576698