Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Side by Side Diff: net/http/http_network_transaction.cc

Issue 1139013002: Completely remove SSLv3 support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_network_transaction.h" 5 #include "net/http/http_network_transaction.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 1417 matching lines...) Expand 10 before | Expand all | Expand 10 after
1428 read_buf_len_ = 0; 1428 read_buf_len_ = 0;
1429 headers_valid_ = false; 1429 headers_valid_ = false;
1430 request_headers_.Clear(); 1430 request_headers_.Clear();
1431 response_ = HttpResponseInfo(); 1431 response_ = HttpResponseInfo();
1432 establishing_tunnel_ = false; 1432 establishing_tunnel_ = false;
1433 } 1433 }
1434 1434
1435 void HttpNetworkTransaction::RecordSSLFallbackMetrics() { 1435 void HttpNetworkTransaction::RecordSSLFallbackMetrics() {
1436 // Note: these values are used in histograms, so new values must be appended. 1436 // Note: these values are used in histograms, so new values must be appended.
1437 enum FallbackVersion { 1437 enum FallbackVersion {
1438 FALLBACK_NONE = 0, // SSL version fallback did not occur. 1438 FALLBACK_NONE = 0, // SSL version fallback did not occur.
1439 FALLBACK_SSL3 = 1, // Fell back to SSL 3.0. 1439 // Obsolete: FALLBACK_SSL3 = 1,
1440 FALLBACK_TLS1 = 2, // Fell back to TLS 1.0. 1440 FALLBACK_TLS1 = 2, // Fell back to TLS 1.0.
1441 FALLBACK_TLS1_1 = 3, // Fell back to TLS 1.1. 1441 FALLBACK_TLS1_1 = 3, // Fell back to TLS 1.1.
1442 FALLBACK_MAX, 1442 FALLBACK_MAX,
1443 }; 1443 };
1444 1444
1445 FallbackVersion fallback = FALLBACK_NONE; 1445 FallbackVersion fallback = FALLBACK_NONE;
1446 if (server_ssl_config_.version_fallback) { 1446 if (server_ssl_config_.version_fallback) {
1447 switch (server_ssl_config_.version_max) { 1447 switch (server_ssl_config_.version_max) {
1448 case SSL_PROTOCOL_VERSION_SSL3:
1449 fallback = FALLBACK_SSL3;
1450 break;
1451 case SSL_PROTOCOL_VERSION_TLS1: 1448 case SSL_PROTOCOL_VERSION_TLS1:
1452 fallback = FALLBACK_TLS1; 1449 fallback = FALLBACK_TLS1;
1453 break; 1450 break;
1454 case SSL_PROTOCOL_VERSION_TLS1_1: 1451 case SSL_PROTOCOL_VERSION_TLS1_1:
1455 fallback = FALLBACK_TLS1_1; 1452 fallback = FALLBACK_TLS1_1;
1456 break; 1453 break;
1457 default: 1454 default:
1458 NOTREACHED(); 1455 NOTREACHED();
1459 } 1456 }
1460 } 1457 }
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 DCHECK(stream_request_); 1619 DCHECK(stream_request_);
1623 1620
1624 // Since the transaction can restart with auth credentials, it may create a 1621 // Since the transaction can restart with auth credentials, it may create a
1625 // stream more than once. Accumulate all of the connection attempts across 1622 // stream more than once. Accumulate all of the connection attempts across
1626 // those streams by appending them to the vector: 1623 // those streams by appending them to the vector:
1627 for (const auto& attempt : stream_request_->connection_attempts()) 1624 for (const auto& attempt : stream_request_->connection_attempts())
1628 connection_attempts_.push_back(attempt); 1625 connection_attempts_.push_back(attempt);
1629 } 1626 }
1630 1627
1631 } // namespace net 1628 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698