Issue 1138993011: Add a way to have three icon menu item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138993011: Add a way to have three icon menu item (Closed)

Created:
5 years, 7 months ago by Yusuf

Modified:
5 years, 7 months ago

Reviewers:
aurimas (slooooooooow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add a way to have three icon menu item Add a layout and constants for supporting a menu item with three icons in it. BUG=478984 Committed: https://crrev.com/b2a22fabff7df7b8fec9e168dc7eac1535c4d713 Cr-Commit-Position: refs/heads/master@{#330649}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -11 lines)			Patch
	A +	chrome/android/java/res/layout/three_button_menu_item.xml	View		2 chunks	+1 line, -9 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java	View		4 chunks	+37 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138993011/1

5 years, 7 months ago (2015-05-19 22:47:03 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 23:15:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b2a22fabff7df7b8fec9e168dc7eac1535c4d713
Cr-Commit-Position: refs/heads/master@{#330649}