Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

Issue 1138993011: Add a way to have three icon menu item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/three_button_menu_item.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
index b605fca3239179b0a66caf75efc30942ab1c95a6..3be0823a51b04cf5318915ffbd5ece4a8e3dd678 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
@@ -42,12 +42,16 @@ class AppMenuAdapter extends BaseAdapter {
/**
* Menu item that has four buttons. Every one of these buttons is displayed as an icon.
*/
- private static final int FOUR_BUTTON_MENU_ITEM = 2;
+ private static final int THREE_BUTTON_MENU_ITEM = 2;
+ /**
+ * Menu item that has four buttons. Every one of these buttons is displayed as an icon.
+ */
+ private static final int FOUR_BUTTON_MENU_ITEM = 3;
/**
* The number of view types specified above. If you add a view type you MUST increment this.
*/
- private static final int VIEW_TYPE_COUNT = 3;
+ private static final int VIEW_TYPE_COUNT = 4;
/** MenuItem Animation Constants */
private static final int ENTER_ITEM_DURATION_MS = 350;
@@ -87,6 +91,8 @@ class AppMenuAdapter extends BaseAdapter {
if (viewCount == 4) {
return FOUR_BUTTON_MENU_ITEM;
+ } else if (viewCount == 3) {
+ return THREE_BUTTON_MENU_ITEM;
} else if (viewCount == 2) {
return TITLE_BUTTON_MENU_ITEM;
}
@@ -145,6 +151,31 @@ class AppMenuAdapter extends BaseAdapter {
convertView.setEnabled(isEnabled);
break;
}
+ case THREE_BUTTON_MENU_ITEM: {
+ ThreeButtonMenuItemViewHolder holder = null;
+ if (convertView == null) {
+ holder = new ThreeButtonMenuItemViewHolder();
+ convertView = mInflater.inflate(R.layout.three_button_menu_item, parent, false);
+ holder.buttons[0] =
+ (TintedImageButton) convertView.findViewById(R.id.button_one);
+ holder.buttons[1] =
+ (TintedImageButton) convertView.findViewById(R.id.button_two);
+ holder.buttons[2] =
+ (TintedImageButton) convertView.findViewById(R.id.button_three);
+ convertView.setTag(holder);
+ convertView.setTag(R.id.menu_item_enter_anim_id,
+ buildIconItemEnterAnimator(holder.buttons));
+ } else {
+ holder = (ThreeButtonMenuItemViewHolder) convertView.getTag();
+ }
+ for (int i = 0; i < 3; i++) {
+ setupImageButton(holder.buttons[i], item.getSubMenu().getItem(i));
+ }
+
+ convertView.setFocusable(false);
+ convertView.setEnabled(false);
+ break;
+ }
case FOUR_BUTTON_MENU_ITEM: {
FourButtonMenuItemViewHolder holder = null;
if (convertView == null) {
@@ -315,6 +346,10 @@ class AppMenuAdapter extends BaseAdapter {
public AppMenuItemIcon image;
}
+ static class ThreeButtonMenuItemViewHolder {
+ public TintedImageButton[] buttons = new TintedImageButton[3];
+ }
+
static class FourButtonMenuItemViewHolder {
public TintedImageButton[] buttons = new TintedImageButton[4];
}
« no previous file with comments | « chrome/android/java/res/layout/three_button_menu_item.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698