Issue 1138973004: Merge to XFA: Fix leaks in the embedder tests themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138973004: Merge to XFA: Fix leaks in the embedder tests themselves. (Closed)

Created:
5 years, 7 months ago by Lei Zhang

Modified:
5 years, 7 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix leaks in the embedder tests themselves. Also change EmbedderTest::TearDown() to match the destruction order in Chromium's PDF code. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1138143003 (cherry picked from commit 61ffad8df484ab9b3f7d2f5519ec470fbc023b88) Committed: https://pdfium.googlesource.com/pdfium/+/d27acae33ff902ee85ae4f8ec76d4f64c294637b

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -19 lines)			Patch
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfformfill_embeddertest.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	fpdfsdk/src/fpdftext_embeddertest.cpp	View	6 chunks	+6 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdfview_embeddertest.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/embedder_test.cpp	View	3 chunks	+10 lines, -16 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 7 months ago (2015-05-15 22:36:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d27acae33ff902ee85ae4f8ec76d4f64c294637b (tree was closed).