Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1138143003: Fix leaks in the embedder tests themselves. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix leaks in the embedder tests themselves. Also change EmbedderTest::TearDown() to match the destruction order in Chromium's PDF code. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/61ffad8df484ab9b3f7d2f5519ec470fbc023b88

Patch Set 1 #

Total comments: 2

Patch Set 2 : one more file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 6 chunks +6 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M samples/pdfium_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 3 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
https://codereview.chromium.org/1138143003/diff/1/testing/embedder_test.cpp File testing/embedder_test.cpp (right): https://codereview.chromium.org/1138143003/diff/1/testing/embedder_test.cpp#newcode215 testing/embedder_test.cpp:215: FORM_DoDocumentAAction(form_handle_, FPDFDOC_AACTION_WC); See PDFiumEngine::~PDFiumEngine().
5 years, 7 months ago (2015-05-15 06:48:57 UTC) #2
Tom Sepez
https://codereview.chromium.org/1138143003/diff/1/testing/embedder_test.cpp File testing/embedder_test.cpp (right): https://codereview.chromium.org/1138143003/diff/1/testing/embedder_test.cpp#newcode215 testing/embedder_test.cpp:215: FORM_DoDocumentAAction(form_handle_, FPDFDOC_AACTION_WC); On 2015/05/15 06:48:57, Lei Zhang wrote: > ...
5 years, 7 months ago (2015-05-15 15:12:40 UTC) #3
Lei Zhang
I added one more file in patch set 2, so all of our code does ...
5 years, 7 months ago (2015-05-15 22:10:21 UTC) #4
Tom Sepez
lgtm
5 years, 7 months ago (2015-05-15 22:11:10 UTC) #5
Lei Zhang
5 years, 7 months ago (2015-05-15 22:13:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
61ffad8df484ab9b3f7d2f5519ec470fbc023b88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698