Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1138933004: Fix apptest builds and runner on Android. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix apptest builds and runner on Android. Serve the build dir when origin is 'localhost'. (so runners can access those output dir .mojos) Build apptests and runner apk for mandoline:all. BUG=486220 TEST=For Android: clobber, build mandoline:all; apptests can run. R=sky@chromium.org Committed: https://crrev.com/d5c5a7e8785b283e9731c77a79fa59ec5bd65849 Cr-Commit-Position: refs/heads/master@{#329509}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Make PrepareShellRun only serve with origin=='localhost'; cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/android_mojo_shell.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/tools/apptest_runner.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M mojo/tools/mopy/android.py View 1 2 7 chunks +13 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 7 months ago (2015-05-12 19:32:46 UTC) #2
sky
https://codereview.chromium.org/1138933004/diff/20001/mojo/tools/mopy/android.py File mojo/tools/mopy/android.py (left): https://codereview.chromium.org/1138933004/diff/20001/mojo/tools/mopy/android.py#oldcode334 mojo/tools/mopy/android.py:334: if origin: I added this code because mandoline doesn't ...
5 years, 7 months ago (2015-05-12 19:39:53 UTC) #3
msw
Please take another look; thanks! https://codereview.chromium.org/1138933004/diff/20001/mojo/tools/mopy/android.py File mojo/tools/mopy/android.py (left): https://codereview.chromium.org/1138933004/diff/20001/mojo/tools/mopy/android.py#oldcode334 mojo/tools/mopy/android.py:334: if origin: On 2015/05/12 ...
5 years, 7 months ago (2015-05-12 20:53:08 UTC) #4
sky
LGTM
5 years, 7 months ago (2015-05-12 21:32:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138933004/40001
5 years, 7 months ago (2015-05-12 21:35:54 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 22:22:54 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 22:24:45 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5c5a7e8785b283e9731c77a79fa59ec5bd65849
Cr-Commit-Position: refs/heads/master@{#329509}

Powered by Google App Engine
This is Rietveld 408576698