mojo/tools/apptest_runner.py - Issue 1138933004: Fix apptest builds and runner on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/tools/apptest_runner.py

Issue 1138933004: Fix apptest builds and runner on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make PrepareShellRun only serve with origin=='localhost'; cleanup. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/tools/apptest_runner.py

diff --git a/mojo/tools/apptest_runner.py b/mojo/tools/apptest_runner.py

index ddc0830712a2bc03919ea534181a273b91254d66..21f25fda82be54748225aa2d3b1fc51cdd1164d9 100755

--- a/mojo/tools/apptest_runner.py

+++ b/mojo/tools/apptest_runner.py

@@ -11,7 +11,6 @@ import sys

from mopy import dart_apptest

from mopy import gtest

-# TODO(msw): Mojo's script pulls in android.py via mojo/devtools/common/pylib.

from mopy.android import AndroidShell

from mopy.config import Config

from mopy.gn import ConfigForGNArgs, ParseGNConfig

@@ -48,7 +47,7 @@ def main():

paths = Paths(config)

shell = AndroidShell(paths.target_mojo_shell_path, paths.build_dir,

paths.adb_path)

- extra_args.extend(shell.PrepareShellRun(fixed_port=False))

+ extra_args.extend(shell.PrepareShellRun('localhost'))

else:

shell = None

« no previous file with comments | « mojo/tools/android_mojo_shell.py ('k') | mojo/tools/mopy/android.py » ('j') | no next file with comments »