Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138923005: Remove SK_LEGACY_DRAWPICTURECALLBACK (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 7 months ago
Reviewers:
danakj, enne (OOO), reed1
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_LEGACY_DRAWPICTURECALLBACK SkDrawPictureCallback is deprecated. Convert existing clients to the equivalent SkPicture::AbortCallback. R=reed@google.com,enne@chromium.org,danakj@chromium.org Committed: https://crrev.com/41d2b2843d29ce49686438323ab0da7dc4ba6c93 Cr-Commit-Position: refs/heads/master@{#330935}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : analysis_canvas_unittest fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -58 lines) Patch
M cc/playback/clip_display_item.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/clip_display_item.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/clip_path_display_item.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/clip_path_display_item.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/compositing_display_item.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/compositing_display_item.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/display_item_list.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/playback/display_item_list.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/playback/display_list_raster_source.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/playback/display_list_raster_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/drawing_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/drawing_display_item.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/playback/filter_display_item.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/filter_display_item.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/float_clip_display_item.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/float_clip_display_item.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/picture.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/picture_pile_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/picture_pile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/transform_display_item.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/playback/transform_display_item.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas.h View 3 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
f(malita)
5 years, 7 months ago (2015-05-20 22:26:43 UTC) #2
enne (OOO)
lgtm
5 years, 7 months ago (2015-05-20 23:44:01 UTC) #3
reed1
lgtm
5 years, 7 months ago (2015-05-21 13:06:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138923005/40001
5 years, 7 months ago (2015-05-21 13:07:19 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 13:12:01 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 13:12:51 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/41d2b2843d29ce49686438323ab0da7dc4ba6c93
Cr-Commit-Position: refs/heads/master@{#330935}

Powered by Google App Engine
This is Rietveld 408576698