skia/ext/analysis_canvas.cc - Issue 1138923005: Remove SK_LEGACY_DRAWPICTURECALLBACK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/analysis_canvas.cc

Issue 1138923005: Remove SK_LEGACY_DRAWPICTURECALLBACK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: analysis_canvas_unittest fix Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/analysis_canvas.cc

diff --git a/skia/ext/analysis_canvas.cc b/skia/ext/analysis_canvas.cc

index 1b8694a1ccccf507552df2f266f416d9d618aec7..102c63e1601e604af24d20dd326525cb965c6563 100644

--- a/skia/ext/analysis_canvas.cc

+++ b/skia/ext/analysis_canvas.cc

@@ -351,7 +351,7 @@ bool AnalysisCanvas::GetColorIfSolid(SkColor* color) const {

return false;

}

-bool AnalysisCanvas::abortDrawing() {

+bool AnalysisCanvas::abort() {

// Early out as soon as we have more than one draw op.

// TODO(vmpstr): Investigate if 1 is the correct metric here. We need to

// balance the amount of time we spend analyzing vs how many tiles would be

« no previous file with comments | « skia/ext/analysis_canvas.h ('k') | skia/ext/analysis_canvas_unittest.cc » ('j') | no next file with comments »