Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1138893003: Convert cr-settings-ui to Polymer 0.8 (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert cr-settings-ui to Polymer 0.8 BUG=485381 Committed: https://crrev.com/e41c0c952beda6b17ef46f68a1231d5c651760ea Cr-Commit-Position: refs/heads/master@{#329530}

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : Jeremy's comments #

Total comments: 1

Patch Set 4 : fix #

Patch Set 5 : rebase. license. #

Patch Set 6 : rerebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -48 lines) Patch
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/resources/settings/settings_ui/settings_ui.css View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 2 1 chunk +12 lines, -17 lines 0 comments Download
D chrome/browser/resources/settings/settings_ui/settings_ui_style.html View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 4 5 4 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
michaelpg
PTAL.
5 years, 7 months ago (2015-05-12 18:17:22 UTC) #2
Jeremy Klein
https://codereview.chromium.org/1138893003/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.css File chrome/browser/resources/settings/settings_ui/settings_ui.css (right): https://codereview.chromium.org/1138893003/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.css#newcode9 chrome/browser/resources/settings/settings_ui/settings_ui.css:9: cr-settings-main core-icon-button { s/core/iron. https://codereview.chromium.org/1138893003/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.html File chrome/browser/resources/settings/settings_ui/settings_ui.html (right): https://codereview.chromium.org/1138893003/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.html#newcode6 ...
5 years, 7 months ago (2015-05-12 18:23:35 UTC) #3
Kyle Horimoto
lgtm after Jeremy's comments.
5 years, 7 months ago (2015-05-12 18:30:02 UTC) #4
michaelpg
https://codereview.chromium.org/1138893003/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.css File chrome/browser/resources/settings/settings_ui/settings_ui.css (right): https://codereview.chromium.org/1138893003/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.css#newcode9 chrome/browser/resources/settings/settings_ui/settings_ui.css:9: cr-settings-main core-icon-button { On 2015/05/12 18:23:34, Jeremy Klein wrote: ...
5 years, 7 months ago (2015-05-12 18:46:16 UTC) #5
Jeremy Klein
lgtm With one comment https://codereview.chromium.org/1138893003/diff/40001/chrome/browser/resources/settings/settings_ui/settings_ui.html File chrome/browser/resources/settings/settings_ui/settings_ui.html (right): https://codereview.chromium.org/1138893003/diff/40001/chrome/browser/resources/settings/settings_ui/settings_ui.html#newcode7 chrome/browser/resources/settings/settings_ui/settings_ui.html:7: <dom-module name="cr-settings-ui"> s/name/id
5 years, 7 months ago (2015-05-12 19:02:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138893003/80001
5 years, 7 months ago (2015-05-12 20:58:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/52590) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-12 21:19:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138893003/120001
5 years, 7 months ago (2015-05-12 22:39:10 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 7 months ago (2015-05-12 23:50:52 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 23:51:48 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e41c0c952beda6b17ef46f68a1231d5c651760ea
Cr-Commit-Position: refs/heads/master@{#329530}

Powered by Google App Engine
This is Rietveld 408576698