Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 1138893003: Convert cr-settings-ui to Polymer 0.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rerebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index 83cf803b5c0c7c227d57683e5e1baee491c087bc..d0c05c41c471fa20ed1b5dbc19a0f05bc30f2043 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -13,30 +13,25 @@
* @group Chrome Settings Elements
* @element cr-settings-ui
*/
-Polymer('cr-settings-ui', {
- publish: {
+Polymer({
+ is: 'cr-settings-ui',
+
+ properties: {
/**
* Preferences state.
- *
- * @attribute prefs
- * @type CrSettingsPrefsElement
- * @default null
+ * @type {?CrSettingsPrefsElement}
*/
- prefs: null,
+ prefs: Object,
/**
* Ordered list of settings pages available to the user. Do not edit
* this variable directly.
- *
- * @attribute pages
- * @type Array<!Object>
- * @default null
+ * @type {!Array<!HTMLElement>}
*/
- pages: null,
- },
-
- /** @override */
- created: function() {
- this.pages = [];
+ pages: {
+ type: Array,
+ value: function() { return []; },
+ notify: true,
+ },
},
});

Powered by Google App Engine
This is Rietveld 408576698