Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1138883004: Revert of Revert of Drive: Let DriveUploader use batch request API. (Closed)

Created:
5 years, 7 months ago by hirono
Modified:
5 years, 7 months ago
Reviewers:
kinaba, sergeyv, tzik
CC:
chromium-reviews, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Drive: Let DriveUploader use batch request API. (patchset #1 id:1 of https://codereview.chromium.org/1135353004/) Reason for revert: The failure is not caused by the patch. MigrationSingleClientTest.AllTypesIndividually looks flaky. Original issue's description: > Revert of Drive: Let DriveUploader use batch request API. (patchset #7 id:120001 of https://codereview.chromium.org/1134633003/) > > Reason for revert: > MigrationSingleClientTest.AllTypesIndividually is broken by this change on Linux GN: > > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28327 > > Original issue's description: > > Drive: Let DriveUploader use batch request API. > > > > The CL lets DriveUploader use batch request API. DriveUploader does asynchronous > > preparation before calling API on service interface. To hold batch request > > during the asynchronous preparation, the CL introduce refcounted hepler class, > > which manages life time of batch request configurator. > > > > BUG=451917 > > TEST=DriveUploaderTest > > > > Committed: https://crrev.com/9cf453b74c8790f6d7a91f958ec998a9fa5a1fa0 > > Cr-Commit-Position: refs/heads/master@{#329599} > > TBR=kinaba@chromium.org,tzik@chromium.org,hirono@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=451917 > > Committed: https://crrev.com/e244812ae9a09d001f24f9aaaf780c80f976d790 > Cr-Commit-Position: refs/heads/master@{#329610} TBR=kinaba@chromium.org,tzik@chromium.org,sergeyv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451917 Committed: https://crrev.com/09b621eaa36477b9b157bbb12fc83865fc6da4bc Cr-Commit-Position: refs/heads/master@{#329613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -76 lines) Patch
M chrome/browser/chromeos/drive/job_queue.cc View 1 chunk +11 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 3 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/drive/drive_uploader.h View 5 chunks +25 lines, -4 lines 0 comments Download
M chrome/browser/drive/drive_uploader.cc View 6 chunks +50 lines, -6 lines 0 comments Download
M chrome/browser/drive/drive_uploader_unittest.cc View 5 chunks +215 lines, -27 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hirono
Created Revert of Revert of Drive: Let DriveUploader use batch request API.
5 years, 7 months ago (2015-05-13 10:18:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138883004/1
5 years, 7 months ago (2015-05-13 10:18:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 10:19:34 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 10:20:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09b621eaa36477b9b157bbb12fc83865fc6da4bc
Cr-Commit-Position: refs/heads/master@{#329613}

Powered by Google App Engine
This is Rietveld 408576698