Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: google_apis/drive/drive_api_requests_unittest.cc

Issue 1138883004: Revert of Revert of Drive: Let DriveUploader use batch request API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/drive/drive_api_requests.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/drive_api_requests_unittest.cc
diff --git a/google_apis/drive/drive_api_requests_unittest.cc b/google_apis/drive/drive_api_requests_unittest.cc
index d83292e988f9cdfd1ccc4de9ecf46857b78598ed..9d69513615d9589b2c6d3f07a73bba1a878c2a76 100644
--- a/google_apis/drive/drive_api_requests_unittest.cc
+++ b/google_apis/drive/drive_api_requests_unittest.cc
@@ -2015,9 +2015,12 @@
}
TEST_F(DriveApiRequestsTest, EmptyBatchUploadRequest) {
- scoped_ptr<drive::BatchUploadRequest> request(new drive::BatchUploadRequest(
- request_sender_.get(), *url_generator_));
- EXPECT_DEATH(request->Commit(), "");
+ drive::BatchUploadRequest* const request =
+ new drive::BatchUploadRequest(request_sender_.get(), *url_generator_);
+ base::WeakPtr<drive::BatchUploadRequest> weak_ptr =
+ request->GetWeakPtrAsBatchUploadRequest();
+ request->Commit();
+ ASSERT_FALSE(weak_ptr.get());
}
TEST(ParseMultipartResponseTest, Empty) {
« no previous file with comments | « google_apis/drive/drive_api_requests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698