Issue 113883002: Create associated packages for the dart:collection and dart:async libs.

Issue 113883002: Create associated packages for the dart:collection and dart:async libs. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen

Modified:
7 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Create associated packages for the dart:collection and dart:async libs. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31260

Patch Set 2 : Moved collection_helper to collection/typed_data #

Patch Set 3 : Split sequence_zip into pkg:async and pkg:collection. #

Total comments: 2

Patch Set 4 : Update SDK dependency to 1.0.0 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -3905 lines)			Patch
M	pkg/args/lib/args.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/args/lib/src/options.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/args/pubspec.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	pkg/async/README.md	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
A +	pkg/async/lib/async.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
A	pkg/async/pubspec.yaml	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	pkg/collection/README.md	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
A +	pkg/collection/lib/algorithms.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection/lib/collection.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	pkg/collection/lib/equality.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection/lib/src/unmodifiable_wrappers.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection/lib/wrappers.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	pkg/collection/pubspec.yaml	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	pkg/collection/test/algorithms_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	pkg/collection/test/equality_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection/test/unmodifiable_collection_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection/test/wrapper_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/collection_helpers/README.md	View	1	1 chunk	+6 lines, -52 lines	0 comments	Download
M	pkg/collection_helpers/lib/algorithms.dart	View	1	1 chunk	+2 lines, -295 lines	0 comments	Download
M	pkg/collection_helpers/lib/all.dart	View	1	1 chunk	+1 line, -12 lines	0 comments	Download
M	pkg/collection_helpers/lib/equality.dart	View	1	1 chunk	+2 lines, -413 lines	0 comments	Download
M	pkg/collection_helpers/lib/typed_buffers.dart	View	1	1 chunk	+2 lines, -229 lines	0 comments	Download
D	pkg/collection_helpers/lib/unmodifiable_wrappers.dart	View	1	1 chunk	+0 lines, -251 lines	0 comments	Download
M	pkg/collection_helpers/lib/wrappers.dart	View	1	1 chunk	+2 lines, -328 lines	0 comments	Download
M	pkg/collection_helpers/pubspec.yaml	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download
D	pkg/collection_helpers/test/algorithms_test.dart	View	1	1 chunk	+0 lines, -271 lines	0 comments	Download
D	pkg/collection_helpers/test/equality_test.dart	View	1	1 chunk	+0 lines, -164 lines	0 comments	Download
D	pkg/collection_helpers/test/typed_buffers_test.dart	View	1	1 chunk	+0 lines, -421 lines	0 comments	Download
D	pkg/collection_helpers/test/unmodifiable_collection_test.dart	View	1	1 chunk	+0 lines, -629 lines	0 comments	Download
D	pkg/collection_helpers/test/wrapper_test.dart	View	1	1 chunk	+0 lines, -255 lines	0 comments	Download
M	pkg/logging/lib/logging.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/math/lib/math.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	pkg/math/pubspec.yaml	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/pkg.status	View	1 2	4 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/sequence_zip/lib/iterable_zip.dart	View	1 2	1 chunk	+3 lines, -56 lines	0 comments	Download
M	pkg/sequence_zip/lib/sequence_zip.dart	View	1 2	1 chunk	+5 lines, -9 lines	0 comments	Download
M	pkg/sequence_zip/lib/stream_zip.dart	View	1 2	1 chunk	+3 lines, -116 lines	0 comments	Download
M	pkg/sequence_zip/pubspec.yaml	View	1 2	1 chunk	+7 lines, -5 lines	0 comments	Download
D	pkg/sequence_zip/test/iterable_test.dart	View	1 2	1 chunk	+0 lines, -112 lines	0 comments	Download
D	pkg/sequence_zip/test/stream_test.dart	View	1 2	1 chunk	+0 lines, -231 lines	0 comments	Download
A	pkg/typed_data/README.md	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	pkg/typed_data/lib/typed_buffers.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/typed_data/lib/typed_data.dart	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
A	pkg/typed_data/pubspec.yaml	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	pkg/typed_data/test/typed_buffers_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unmodifiable_collection/lib/unmodifiable_collection.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/unmodifiable_collection/pubspec.yaml	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/version.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/list.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

I created the "math" and "typed_data" packages as well. Moved code from pkg:sequence_zip and pkg:collection_helpers ...

7 years ago (2013-12-19 10:50:41 UTC) #3

Søren Gjesse

LGTM https://codereview.chromium.org/113883002/diff/30001/pkg/async/pubspec.yaml File pkg/async/pubspec.yaml (right): https://codereview.chromium.org/113883002/diff/30001/pkg/async/pubspec.yaml#newcode9 pkg/async/pubspec.yaml:9: sdk: ">=0.8.10+6 <2.0.0" Shouldn't we just go for ...

7 years ago (2013-12-19 11:01:37 UTC) #4

Lasse Reichstein Nielsen

Committed patchset #4 manually as r31260 (presubmit successful).

7 years ago (2013-12-19 11:58:36 UTC) #5

Lasse Reichstein Nielsen

7 years ago (2013-12-19 13:39:51 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/113883002/diff/30001/pkg/async/pubspec.yaml
File pkg/async/pubspec.yaml (right):

https://codereview.chromium.org/113883002/diff/30001/pkg/async/pubspec.yaml#n...
pkg/async/pubspec.yaml:9: sdk: ">=0.8.10+6 <2.0.0"
Absolutely, well spotted.

Expand Messages | Collapse Messages