fpdfsdk/include/javascript/JS_Runtime.h - Issue 1138823004: Replace v8::Handle with v8::Local and v8::Persistent with v8::Global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_Runtime.h

Issue 1138823004: Replace v8::Handle with v8::Local and v8::Persistent with v8::Global (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/javascript/JS_Runtime.h

diff --git a/fpdfsdk/include/javascript/JS_Runtime.h b/fpdfsdk/include/javascript/JS_Runtime.h

index 5326db693dec45b3e9d22ef977d5f59c880d7d3e..1f51638bf9bcba9cb0d89fc71b8cdb6d62cc190c 100644

--- a/fpdfsdk/include/javascript/JS_Runtime.h

+++ b/fpdfsdk/include/javascript/JS_Runtime.h

@@ -58,7 +58,7 @@ public:

v8::Isolate* GetIsolate(){return m_isolate;};

void SetIsolate(v8::Isolate* isolate){m_isolate = isolate;}

- v8::Handle<v8::Context> NewJSContext();

+ v8::Local<v8::Context> NewJSContext();

protected:

CFX_ArrayTemplate<CJS_Context*> m_ContextArray;

CPDFDoc_Environment* m_pApp;

@@ -69,7 +69,7 @@ protected:

v8::Isolate* m_isolate;

nonstd::unique_ptr<CJS_ArrayBufferAllocator> m_pArrayBufferAllocator;

- v8::Persistent<v8::Context> m_context;

+ v8::Global<v8::Context> m_context;

};

#endif //_JS_RUNTIME_H_

« no previous file with comments | « fpdfsdk/include/javascript/JS_Object.h ('k') | fpdfsdk/include/javascript/JS_Value.h » ('j') | no next file with comments »