Fix continuous read in ChromeVox Next.

Fix continuous read in ChromeVox Next.

- remove cancel utterance logic which incorrectly calls endCallback causing unexpected continuation of speech on stop().
- adds mapping for continuous read in compat mode.
- fixes continuous read test which is still prefixed manual.

TEST=verify continuous read works in ChromeVox Next and compat. Passes BackgroundTest.MANUAL_ContinuousRead

Committed: https://crrev.com/8793bf2e30bf977047ee88c57e91d05d414030ca
Cr-Commit-Position: refs/heads/master@{#329229}

[David Tseng, 2015-05-11 18:42:42]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-05-11 18:45:26]

Not calling the endCallback leads to a memory leak for ChromeVox classic, since
it keeps a mapping around from the callback id to the callback function. Could
we instead add a separate cancelled callback?

[David Tseng, 2015-05-11 19:23:51]

PTAL. You're right; now checking for the opt_cleanupOnly arg in the Next
callback.

On Mon, May 11, 2015 at 11:45 AM, <dmazzoni@chromium.org> wrote:

> Not calling the endCallback leads to a memory leak for ChromeVox classic,
> since
> it keeps a mapping around from the callback id to the callback function.
> Could
> we instead add a separate cancelled callback?
>
>
> https://codereview.chromium.org/1138813002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-05-11 19:36:59]

lgtm

[David Tseng, 2015-05-11 19:49:59]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138813002/20001

[commit-bot: I haz the power, 2015-05-11 19:58:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:58:31]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2015-05-11 20:34:41]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2015-05-11 20:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138813002/20001

[commit-bot: I haz the power, 2015-05-11 20:41:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-11 20:42:26]

Patchset 2 (id:??) landed as
https://crrev.com/8793bf2e30bf977047ee88c57e91d05d414030ca
Cr-Commit-Position: refs/heads/master@{#329229}