chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 1138813002: Fix continuous read in ChromeVox Next.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 1138813002: Fix continuous read in ChromeVox Next. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check opt_cleanupOnly Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/classic_compatibility.js ('k') | chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index e54e2d1c9d3de8b8b577f7c6e67e2691040be9b3..3be31387ffb3b7cb16a2a2ecb9f57c6eea95bcb7 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -52,7 +52,7 @@ Output = function() {

this.brailleBuffer_ = [];

/** @type {!Array<Object>} */

this.locations_ = [];

- /** @type {function()} */

+ /** @type {function(?)} */

this.speechEndCallback_;

/**

@@ -614,7 +614,10 @@ Output.prototype = {

* @param {function()} callback

onSpeechEnd: function(callback) {

- this.speechEndCallback_ = callback;

+ this.speechEndCallback_ = function(opt_cleanupOnly) {

+ if (!opt_cleanupOnly)

+ callback();

+ }.bind(this);

return this;