[Android] Disable tombstones for renderer crashes on JB MR2+

[Android] Disable tombstones for renderer crashes on JB MR2+

Starting with JB MR2, a crashing service triggers a dialog. This is an
awful user experience when a Chrome renderer crashes. The system service
that triggers the dialog also prints the stacktrace to the log and
creates a tombstone.

For now, disable the tombstone and dialog on JB MR2+ "user" builds (or
rather, non-"userdebug", non-"eng" builds).

BUG=273706
TEST=navigate to "about:crash". If on JB MR2+ "user" build, no system
dialog should be shown. Otherwise, dialog should be shown.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251183

[cjhopman, 2013-12-16 23:08:06]

yfriedman: *

[Yaron, 2013-12-17 01:22:52]

https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
File components/breakpad/app/breakpad_linux.cc (right):

https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
components/breakpad/app/breakpad_linux.cc:708:
strcmp(android_build_info->build_type(), "eng") != 0 &&
Why not explicitly check for user builds? Are you afraid of random strings?

[cjhopman, 2013-12-17 01:28:32]

On 2013/12/17 01:22:52, Yaron wrote:
>
https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
> File components/breakpad/app/breakpad_linux.cc (right):
> 
>
https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
> components/breakpad/app/breakpad_linux.cc:708:
> strcmp(android_build_info->build_type(), "eng") != 0 &&
> Why not explicitly check for user builds? Are you afraid of random strings?

Yeah, I sort of thought the default should be to disable the tombstone. I don't
think this can ever be anything other than "user", "userdebug", or "eng" though.

[Yaron, 2014-02-04 16:56:42]

On 2013/12/17 01:28:32, cjhopman wrote:
> On 2013/12/17 01:22:52, Yaron wrote:
> >
>
https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
> > File components/breakpad/app/breakpad_linux.cc (right):
> > 
> >
>
https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
> > components/breakpad/app/breakpad_linux.cc:708:
> > strcmp(android_build_info->build_type(), "eng") != 0 &&
> > Why not explicitly check for user builds? Are you afraid of random strings?
> 
> Yeah, I sort of thought the default should be to disable the tombstone. I
don't
> think this can ever be anything other than "user", "userdebug", or "eng"
though.

What's the status of this? Can you re-sync it so we can get it in

[cjhopman, 2014-02-04 21:49:28]

On 2014/02/04 16:56:42, Yaron wrote:
> On 2013/12/17 01:28:32, cjhopman wrote:
> > On 2013/12/17 01:22:52, Yaron wrote:
> > >
> >
>
https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
> > > File components/breakpad/app/breakpad_linux.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/113873006/diff/1/components/breakpad/app/brea...
> > > components/breakpad/app/breakpad_linux.cc:708:
> > > strcmp(android_build_info->build_type(), "eng") != 0 &&
> > > Why not explicitly check for user builds? Are you afraid of random
strings?
> > 
> > Yeah, I sort of thought the default should be to disable the tombstone. I
> don't
> > think this can ever be anything other than "user", "userdebug", or "eng"
> though.
> 
> What's the status of this? Can you re-sync it so we can get it in

It's rebased.

[Yaron, 2014-02-04 23:10:15]

lgtm

[cjhopman, 2014-02-04 23:19:31]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-02-04 23:29:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/113873006/30001

[commit-bot: I haz the power, 2014-02-05 01:34:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/113873006/30001

[commit-bot: I haz the power, 2014-02-05 04:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-05 04:24:11]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[cjhopman, 2014-02-12 21:27:48]

cpu@chromium.org: components/breakpad

[cpu_(ooo_6.6-7.5), 2014-02-13 03:33:29]

rubberstamp lgtm

[cjhopman, 2014-02-13 18:24:10]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:25:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/113873006/340001

[commit-bot: I haz the power, 2014-02-13 19:57:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/113873006/340001

[commit-bot: I haz the power, 2014-02-13 23:26:56]

Change committed as 251183