[Android] Disable tombstones for renderer crashes on JB MR2+

components/breakpad/app/breakpad_linux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // For linux_syscall_support.h. This makes it safe to call embedded system
 // calls when in seccomp mode.
 
 #include "components/breakpad/app/breakpad_linux.h"
 
 #include <fcntl.h>
@@ skipping 683 matching lines @@
   info.fd = descriptor.fd();
   info.process_type = g_process_type;
   info.process_type_length = my_strlen(g_process_type);
   info.distro = distro;
   info.distro_length = distro_length;
   info.upload = false;
   info.process_start_time = g_process_start_time;
   info.pid = g_pid;
   info.crash_keys = g_crash_keys;
   HandleCrashDump(info);
-  return FinalizeCrashDoneAndroid();
+  bool finalize_result = FinalizeCrashDoneAndroid();
+  base::android::BuildInfo* android_build_info =
+      base::android::BuildInfo::GetInstance();
+  if (android_build_info->sdk_int() >= 18 &&
+      strcmp(android_build_info->build_type(), "eng") != 0 &&

[Yaron, 2013/12/17 01:22:52]

Why not explicitly check for user builds? Are you afraid of random strings?

+      strcmp(android_build_info->build_type(), "userdebug") != 0) {
+    // On JB MR2 and later, the system crash handler displays a dialog. For
+    // renderer crashes, this is a bad user experience and so this is disabled
+    // for user builds of Android.
+    // TODO(cjhopman): There should be some way to recover the crash stack from
+    // non-uploading user clients. See http://crbug.com/273706.
+    __android_log_write(ANDROID_LOG_WARN,
+                        kGoogleBreakpad,
+                        "Tombstones are disabled on JB MR2+ user builds.");
+    __android_log_write(ANDROID_LOG_WARN,
+                        kGoogleBreakpad,
+                        "### ### ### ### ### ### ### ### ### ### ### ### ###");
+    return true;
+  } else {
+    return finalize_result;
+  }
 }
 
 void EnableNonBrowserCrashDumping(const std::string& process_type,
                                   int minidump_fd) {
   // This will guarantee that the BuildInfo has been initialized and subsequent
   // calls will not require memory allocation.
   base::android::BuildInfo::GetInstance();
   SetClientIdFromCommandLine(*CommandLine::ForCurrentProcess());
 
   // On Android, the current sandboxing uses process isolation, in which the
@@ skipping 799 matching lines @@
     }
   }
 }
 #endif  // OS_ANDROID
 
 bool IsCrashReporterEnabled() {
   return g_is_crash_reporter_enabled;
 }
 
 }  // namespace breakpad