Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1138563002: Add DisplayScheduler for Surfaces (Closed)

Created:
5 years, 7 months ago by brianderson
Modified:
5 years, 7 months ago
Reviewers:
sunnyps, sky, jbauman, mithro-old
CC:
alexst (slow to review), cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rendererLatencyRecoveryHeuristic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DisplayScheduler for Surfaces This uses a SyntheticBeginFrameSource and a BeginFrame + deadline to determine when to draw. A heuristic is used to detect currently active surfaces that we want to wait for. Future patches will put this in charge of sending BeginFrames to surface producers, avoid using a heuristic to detect currently active surfaces, and more reliably inform producers of their latency. BUG=467750 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e3d8fe5e6b5a1fe7ba627cc124b7ad77ec8c2f7d Cr-Commit-Position: refs/heads/master@{#331037}

Patch Set 1 #

Patch Set 2 : fix existing tests; new tests still to come #

Patch Set 3 : remove whitespace change #

Patch Set 4 : immediate deadline when swap ack throttled again #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+849 lines, -138 lines) Patch
M cc/cc.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/surfaces/display.h View 5 chunks +10 lines, -4 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 3 4 5 8 chunks +38 lines, -18 lines 0 comments Download
M cc/surfaces/display_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
A cc/surfaces/display_scheduler.h View 1 1 chunk +91 lines, -0 lines 0 comments Download
A cc/surfaces/display_scheduler.cc View 1 2 3 1 chunk +273 lines, -0 lines 0 comments Download
A cc/surfaces/display_scheduler_unittest.cc View 1 2 3 1 chunk +321 lines, -0 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 11 chunks +78 lines, -39 lines 0 comments Download
M cc/surfaces/onscreen_display_client.h View 1 2 3 4 3 chunks +4 lines, -14 lines 0 comments Download
M cc/surfaces/onscreen_display_client.cc View 3 chunks +20 lines, -44 lines 0 comments Download
M components/surfaces/display_impl.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M components/surfaces/display_impl.cc View 1 2 3 4 5 2 chunks +7 lines, -12 lines 0 comments Download
M components/surfaces/surfaces_scheduler.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/surfaces/surfaces_scheduler.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
brianderson
This first patch set here differs from the last patch set of https://codereview.chromium.org/1012853003/ in the ...
5 years, 7 months ago (2015-05-08 20:58:50 UTC) #2
brianderson
Looking to re-land this now that we've branched and I landed the regression test in ...
5 years, 7 months ago (2015-05-19 20:31:43 UTC) #3
brianderson
+Alex as FYI
5 years, 7 months ago (2015-05-19 22:11:20 UTC) #4
jbauman
lgtm
5 years, 7 months ago (2015-05-20 22:53:59 UTC) #5
brianderson
+sky for owner's review of components/surfaces
5 years, 7 months ago (2015-05-20 22:56:30 UTC) #7
sky
As long as components/surfaces still works, LGTM
5 years, 7 months ago (2015-05-20 23:11:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138563002/80001
5 years, 7 months ago (2015-05-21 15:07:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/78980)
5 years, 7 months ago (2015-05-21 18:16:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138563002/80001
5 years, 7 months ago (2015-05-21 20:49:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/79236) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-21 20:58:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138563002/100001
5 years, 7 months ago (2015-05-21 21:14:27 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-22 00:45:39 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 00:46:33 UTC) #21
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e3d8fe5e6b5a1fe7ba627cc124b7ad77ec8c2f7d
Cr-Commit-Position: refs/heads/master@{#331037}

Powered by Google App Engine
This is Rietveld 408576698