Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1124273004: Add SurfaceDisplayOutputSurface unittests (Closed)

Created:
5 years, 7 months ago by brianderson
Modified:
5 years, 7 months ago
Reviewers:
jbauman
CC:
cc-bugs_chromium.org, chromium-reviews, mithro-old, sunnyps
Base URL:
https://chromium.googlesource.com/chromium/src.git@displayScheduler16
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SurfaceDisplayOutputSurface unittests Three basic tests added: 1) DamageTriggersSwapBuffers 2) NoDamageDoesNotTriggerSwapBuffers 3) LockingResourcesDoesIndirectlyCauseDamage The last test is a regression test to make sure we don't accidentally damage the root surface every frame. It fails with the following patch applied, which got reverted: https://codereview.chromium.org/1073323002 BUG=476544 Committed: https://crrev.com/8eaf23b2f5ed71c59d6597f90dbf5d2409e36e55 Cr-Commit-Position: refs/heads/master@{#329991}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : DoesIndrectly -> DoesNotIndirectly #

Total comments: 1

Patch Set 4 : delete unnecessary test class #

Patch Set 5 : rebase on ToT, can land before DisplayScheduler patch #

Patch Set 6 : simplify #

Patch Set 7 : mroe checks to help debug flake #

Patch Set 8 : Remove debug code and fix flakiness due to uninitialized variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -0 lines) Patch
M cc/cc_tests.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/onscreen_display_client.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A cc/surfaces/surface_display_output_surface_unittest.cc View 1 2 3 4 5 6 7 1 chunk +147 lines, -0 lines 0 comments Download
M cc/test/ordered_simple_task_runner.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
brianderson
ptal!
5 years, 7 months ago (2015-05-12 03:25:28 UTC) #2
brianderson
https://codereview.chromium.org/1124273004/diff/40001/cc/surfaces/surface_display_output_surface_unittest.cc File cc/surfaces/surface_display_output_surface_unittest.cc (right): https://codereview.chromium.org/1124273004/diff/40001/cc/surfaces/surface_display_output_surface_unittest.cc#newcode47 cc/surfaces/surface_display_output_surface_unittest.cc:47: class TestSurfaceDisplayOutputSurface : public SurfaceDisplayOutputSurface { I guess this ...
5 years, 7 months ago (2015-05-12 17:01:20 UTC) #3
brianderson
Found the uninitialized variable - it was coming up as 0 on my Windows machine ...
5 years, 7 months ago (2015-05-14 23:24:04 UTC) #4
jbauman
lgtm
5 years, 7 months ago (2015-05-14 23:29:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124273004/140001
5 years, 7 months ago (2015-05-14 23:37:23 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 7 months ago (2015-05-15 00:24:14 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:25:22 UTC) #9
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/8eaf23b2f5ed71c59d6597f90dbf5d2409e36e55
Cr-Commit-Position: refs/heads/master@{#329991}

Powered by Google App Engine
This is Rietveld 408576698