Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: ash/accelerators/accelerator_table.cc

Issue 1138523006: Enable keyboard accelerators while a menu is open (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename the enum values Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_table.cc
diff --git a/ash/accelerators/accelerator_table.cc b/ash/accelerators/accelerator_table.cc
index a7f48e7d7b0116e29422230682df4d830209cdc4..aeb86730d0975abc0d890543ccd8073aabbab53e 100644
--- a/ash/accelerators/accelerator_table.cc
+++ b/ash/accelerators/accelerator_table.cc
@@ -472,4 +472,33 @@ const AcceleratorAction kActionsNeedingWindow[] = {
const size_t kActionsNeedingWindowLength = arraysize(kActionsNeedingWindow);
+const AcceleratorAction kActionsKeepingMenuOpen[] = {
+ MEDIA_NEXT_TRACK,
+ MEDIA_PLAY_PAUSE,
+ MEDIA_PREV_TRACK,
+ NEXT_IME,
+ PREVIOUS_IME,
+ PRINT_UI_HIERARCHIES,
+ SWITCH_IME,
+ TAKE_PARTIAL_SCREENSHOT,
+ TAKE_SCREENSHOT,
+#if defined(OS_CHROMEOS)
+ BRIGHTNESS_DOWN,
+ BRIGHTNESS_UP,
+ DISABLE_CAPS_LOCK,
+ DISABLE_GPU_WATCHDOG,
pkotwicz 2015/09/10 19:13:00 Did you get UX feedback on the accelerators which
afakhry 2015/09/10 20:57:13 I just spoke to Albert, we can definitely take UX
+ KEYBOARD_BRIGHTNESS_DOWN,
+ KEYBOARD_BRIGHTNESS_UP,
+ SILENCE_SPOKEN_FEEDBACK,
+ TOGGLE_CAPS_LOCK,
+ TOGGLE_SPOKEN_FEEDBACK,
+ TOGGLE_WIFI,
+ VOLUME_DOWN,
+ VOLUME_MUTE,
+ VOLUME_UP,
+#endif // defined(OS_CHROMEOS)
+};
+
+const size_t kActionsKeepingMenuOpenLength = arraysize(kActionsKeepingMenuOpen);
+
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698