Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: ash/accelerators/accelerator_table.cc

Issue 1138523006: Enable keyboard accelerators while a menu is open (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename the enum values Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_table.h" 5 #include "ash/accelerators/accelerator_table.h"
6 6
7 #include "ash/strings/grit/ash_strings.h" 7 #include "ash/strings/grit/ash_strings.h"
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 9
10 namespace ash { 10 namespace ash {
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 WINDOW_CYCLE_SNAP_DOCK_RIGHT, 465 WINDOW_CYCLE_SNAP_DOCK_RIGHT,
466 WINDOW_MINIMIZE, 466 WINDOW_MINIMIZE,
467 TOGGLE_FULLSCREEN, 467 TOGGLE_FULLSCREEN,
468 TOGGLE_MAXIMIZED, 468 TOGGLE_MAXIMIZED,
469 WINDOW_POSITION_CENTER, 469 WINDOW_POSITION_CENTER,
470 ROTATE_WINDOW, 470 ROTATE_WINDOW,
471 }; 471 };
472 472
473 const size_t kActionsNeedingWindowLength = arraysize(kActionsNeedingWindow); 473 const size_t kActionsNeedingWindowLength = arraysize(kActionsNeedingWindow);
474 474
475 const AcceleratorAction kActionsKeepingMenuOpen[] = {
476 MEDIA_NEXT_TRACK,
477 MEDIA_PLAY_PAUSE,
478 MEDIA_PREV_TRACK,
479 NEXT_IME,
480 PREVIOUS_IME,
481 PRINT_UI_HIERARCHIES,
482 SWITCH_IME,
483 TAKE_PARTIAL_SCREENSHOT,
484 TAKE_SCREENSHOT,
485 #if defined(OS_CHROMEOS)
486 BRIGHTNESS_DOWN,
487 BRIGHTNESS_UP,
488 DISABLE_CAPS_LOCK,
489 DISABLE_GPU_WATCHDOG,
pkotwicz 2015/09/10 19:13:00 Did you get UX feedback on the accelerators which
afakhry 2015/09/10 20:57:13 I just spoke to Albert, we can definitely take UX
490 KEYBOARD_BRIGHTNESS_DOWN,
491 KEYBOARD_BRIGHTNESS_UP,
492 SILENCE_SPOKEN_FEEDBACK,
493 TOGGLE_CAPS_LOCK,
494 TOGGLE_SPOKEN_FEEDBACK,
495 TOGGLE_WIFI,
496 VOLUME_DOWN,
497 VOLUME_MUTE,
498 VOLUME_UP,
499 #endif // defined(OS_CHROMEOS)
500 };
501
502 const size_t kActionsKeepingMenuOpenLength = arraysize(kActionsKeepingMenuOpen);
503
475 } // namespace ash 504 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698