Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1138483005: Reland "Mark internal AccessorInfo properties as 'special data properties'" (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Mark internal AccessorInfo properties as 'special data properties'" This reverts commit ac5336baca8c1ee45be0157aa1d4f9a178d75bb6. BUG= Committed: https://crrev.com/4268141ca691bb0e26fc5d6ee6ae0493035d8883 Cr-Commit-Position: refs/heads/master@{#28442}

Patch Set 1 : Original commit failing test #

Patch Set 2 : Fix #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M src/accessors.cc View 7 chunks +1 line, -37 lines 0 comments Download
M src/ic/ic.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/array-length.js View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/es6/arguments-iterator.js View 1 chunk +1 line, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-489151.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-18 11:23:04 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/1138483005/diff/20001/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/1138483005/diff/20001/src/ic/ic.cc#newcode1668 src/ic/ic.cc:1668: (!AccessorInfo::cast(*accessors)->is_special_data_property() || Maybe it's better ...
5 years, 7 months ago (2015-05-18 11:53:15 UTC) #3
Toon Verwaest
Addressed comment
5 years, 7 months ago (2015-05-18 12:01:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138483005/40001
5 years, 7 months ago (2015-05-18 12:09:26 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 12:36:55 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 12:37:15 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4268141ca691bb0e26fc5d6ee6ae0493035d8883
Cr-Commit-Position: refs/heads/master@{#28442}

Powered by Google App Engine
This is Rietveld 408576698