Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects-inl.h

Issue 1138483005: Reland "Mark internal AccessorInfo properties as 'special data properties'" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/array-length.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7037 matching lines...) Expand 10 before | Expand all | Expand 10 after
7048 bool AccessorInfo::all_can_write() { 7048 bool AccessorInfo::all_can_write() {
7049 return BooleanBit::get(flag(), kAllCanWriteBit); 7049 return BooleanBit::get(flag(), kAllCanWriteBit);
7050 } 7050 }
7051 7051
7052 7052
7053 void AccessorInfo::set_all_can_write(bool value) { 7053 void AccessorInfo::set_all_can_write(bool value) {
7054 set_flag(BooleanBit::set(flag(), kAllCanWriteBit, value)); 7054 set_flag(BooleanBit::set(flag(), kAllCanWriteBit, value));
7055 } 7055 }
7056 7056
7057 7057
7058 bool AccessorInfo::is_special_data_property() {
7059 return BooleanBit::get(flag(), kSpecialDataProperty);
7060 }
7061
7062
7063 void AccessorInfo::set_is_special_data_property(bool value) {
7064 set_flag(BooleanBit::set(flag(), kSpecialDataProperty, value));
7065 }
7066
7067
7058 PropertyAttributes AccessorInfo::property_attributes() { 7068 PropertyAttributes AccessorInfo::property_attributes() {
7059 return AttributesField::decode(static_cast<uint32_t>(flag()->value())); 7069 return AttributesField::decode(static_cast<uint32_t>(flag()->value()));
7060 } 7070 }
7061 7071
7062 7072
7063 void AccessorInfo::set_property_attributes(PropertyAttributes attributes) { 7073 void AccessorInfo::set_property_attributes(PropertyAttributes attributes) {
7064 set_flag(Smi::FromInt(AttributesField::update(flag()->value(), attributes))); 7074 set_flag(Smi::FromInt(AttributesField::update(flag()->value(), attributes)));
7065 } 7075 }
7066 7076
7067 7077
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
7617 #undef READ_SHORT_FIELD 7627 #undef READ_SHORT_FIELD
7618 #undef WRITE_SHORT_FIELD 7628 #undef WRITE_SHORT_FIELD
7619 #undef READ_BYTE_FIELD 7629 #undef READ_BYTE_FIELD
7620 #undef WRITE_BYTE_FIELD 7630 #undef WRITE_BYTE_FIELD
7621 #undef NOBARRIER_READ_BYTE_FIELD 7631 #undef NOBARRIER_READ_BYTE_FIELD
7622 #undef NOBARRIER_WRITE_BYTE_FIELD 7632 #undef NOBARRIER_WRITE_BYTE_FIELD
7623 7633
7624 } } // namespace v8::internal 7634 } } // namespace v8::internal
7625 7635
7626 #endif // V8_OBJECTS_INL_H_ 7636 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/array-length.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698