Make all pdb file names follow the same naming convention.

Make all pdb file names follow the same naming convention.

The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
  * no more chrome_dll.pdb and chrome_exe.pdb silliness
    * also avoids this issue if we end up with similarly named targets in the
      future (target.dll and target.exe)
  * ninja already does this, and, by extension, either ninja needs to be broken
    to use the old scheme, or the we fix the broken in the existing system.
    One less difference between msvs and ninja.

Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015 

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168341

[Sigurður Ásgeirsson, 2012-11-08 20:44:59]

Seems like a good idea, but I think you've missed a couple of places:
chrome/chrome_dll.gypi:                  'ProgramDatabaseFile':
'$(OutDir)\\chrome_dll.pdb',
chrome/chrome_syzygy.gyp:                '<(PRODUCT_DIR)\\chrome_dll.pdb',
chrome/chrome_syzygy.gyp:                '<(dest_dir)\\chrome_dll.pdb',
chrome/chrome_syzygy.gyp:                '--input_symbol',
'<(PRODUCT_DIR)\\chrome_dll.pdb',
chrome/test/functional/stress.py:      symbol_files = ['chrome_dll.pdb',
'chrome_exe.pdb']
chrome/tools/build/win/FILES.cfg:    'filename': 'chrome_dll.pdb',
chrome/tools/build/win/FILES.cfg:    'filename': 'syzygy/chrome_dll.pdb',
chrome/tools/build/win/make_chromebot_zip.sh:sym_files=( chrome_dll.pdb
chrome_exe.pdb )
tools/win/copy-installer.bat:REM incremental_chrome_dll=1 puts chrome_dll.pdb
into the "initial" dir.

I'd talk to folks who understand how the installer is ultimately built to figure
out what else will need changing.

https://chromiumcodereview.appspot.com/11384003/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11384003/diff/1/build/common.gypi#newc...
build/common.gypi:1775: # Make the pdb name sane. Otherwise foo.exe and foo.dll
both have
nit: > 80 chars.

[iannucci, 2012-11-08 21:05:02]

On 2012/11/08 20:44:59, Sigurður Ásgeirsson wrote:
> Seems like a good idea, but I think you've missed a couple of places:
> chrome/chrome_dll.gypi:                  'ProgramDatabaseFile':
> '$(OutDir)\\chrome_dll.pdb',
> chrome/chrome_syzygy.gyp:                '<(PRODUCT_DIR)\\chrome_dll.pdb',
> chrome/chrome_syzygy.gyp:                '<(dest_dir)\\chrome_dll.pdb',
> chrome/chrome_syzygy.gyp:                '--input_symbol',
> '<(PRODUCT_DIR)\\chrome_dll.pdb',
> chrome/test/functional/stress.py:      symbol_files = ['chrome_dll.pdb',
> 'chrome_exe.pdb']
> chrome/tools/build/win/FILES.cfg:    'filename': 'chrome_dll.pdb',
> chrome/tools/build/win/FILES.cfg:    'filename': 'syzygy/chrome_dll.pdb',
> chrome/tools/build/win/make_chromebot_zip.sh:sym_files=( chrome_dll.pdb
> chrome_exe.pdb )
> tools/win/copy-installer.bat:REM incremental_chrome_dll=1 puts chrome_dll.pdb
> into the "initial" dir.
> 
> I'd talk to folks who understand how the installer is ultimately built to
figure
> out what else will need changing.
> 

So I did! Serves me right for working on the same thing in multiple checkouts...
I'll have the rest up in a bit. Sorry about that.

> https://chromiumcodereview.appspot.com/11384003/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/11384003/diff/1/build/common.gypi#newc...
> build/common.gypi:1775: # Make the pdb name sane. Otherwise foo.exe and
foo.dll
> both have
> nit: > 80 chars.

[eroman, 2012-11-08 22:27:05]

General naming change seems good to me.

However you will need to be careful to update all the scripts/tools that depend
on this.

For instance, this internal build script appears to hardcode chrome_exe.pdb:

http://goto/tmpki

[iannucci, 2012-11-08 22:48:02]

On 2012/11/08 22:27:05, eroman wrote:
> General naming change seems good to me.
> 
> However you will need to be careful to update all the scripts/tools that
depend
> on this.
> 
> For instance, this internal build script appears to hardcode chrome_exe.pdb:
> 
> http://goto/tmpki

Yeah if you can think of where other hardcoded badness might be lurking, let me
know (I'm still relatively new to this codebase).

CL for build on chrome-internal (https://chromereviews.googleplex.com/5681015)

[eroman, 2012-11-08 22:53:45]

I searched all the places I knew to look, and that is the only reference I could
turn up :)

[iannucci, 2012-11-08 22:56:07]

On 2012/11/08 22:53:45, eroman wrote:
> I searched all the places I knew to look, and that is the only reference I
could
> turn up :)

Ha ok :). FWIW, I already committed the cl to fix the one I found in
chromium/.../build (https://chromiumcodereview.appspot.com/11396002/).

[dharani, 2012-11-08 23:56:50]

Though this change looks scary to me, I couldn't find any other hardcoded
scripts. However, if you are committing, please do it now or hold it till
Monday. We just need to avoid any surprises during weekend.

[iannucci, 2012-11-09 19:30:09]

On 2012/11/08 23:56:50, dharani wrote:
> Though this change looks scary to me, I couldn't find any other hardcoded
> scripts. However, if you are committing, please do it now or hold it till
> Monday. We just need to avoid any surprises during weekend.

Agreed, will hold till monday.

[Sigurður Ásgeirsson, 2012-11-09 19:38:33]

lgtm. I think you'll need some owners approval, though?

[iannucci, 2012-11-12 19:33:41]

Need owner approval :)

Basic aim of the patch is to make all pdb names match $(TargetPath).pdb. I have
related build script changes that will land at the same time here:
https://chromereviews.googleplex.com/5681015 

Thanks!
R

[alexeypa (please no reviews), 2012-11-12 19:42:12]

remoting/* - lgtm

[M-A Ruel, 2012-11-13 15:42:48]

lgtm, assuming you tried it locally. :)

[commit-bot: I haz the power, 2012-11-14 20:17:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/11384003/8006

[commit-bot: I haz the power, 2012-11-14 20:17:52]

Presubmit check for 11384003-8006 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome_frame
    chrome/tools/build/win
    chrome/installer
    chrome/test/functional

Presubmit checks took 2.8s to calculate.

[grt (UTC plus 2), 2012-11-14 21:35:26]

chrome_frame/ lgtm

[iannucci, 2012-11-14 21:56:55]

Need owner lgtm (gypfiles) for:
chrome/
chrome/test/functional

Thanks :)
R

[Ben Goodger (Google), 2012-11-15 17:11:45]

lgtm

[commit-bot: I haz the power, 2012-11-15 19:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/11384003/8006

[commit-bot: I haz the power, 2012-11-15 20:34:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-16 18:06:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/11384003/25004