Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: chrome/chrome_dll.gypi

Issue 11384003: Make all pdb file names follow the same naming convention. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_dll.gypi
diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi
index 6263e70d3f8cc78b5f9d89b5c6109581f25ee299..54cc0e3f023f2711da765e22f720de0bdbab565d 100644
--- a/chrome/chrome_dll.gypi
+++ b/chrome/chrome_dll.gypi
@@ -32,7 +32,28 @@
'$(OutDir)\\initial\\chrome.dll',
'$(OutDir)\\chrome.dll'],
'msvs_cygwin_shell': 0,
- }
+ },
+ ],
+ 'conditions': [
+ # Only hardlink pdb if we're generating debug info.
+ ['fastbuild==0 or win_z7!=0', {
+ 'actions': [
+ {
+ 'action_name': 'hardlink_pdb_to_output',
+ 'inputs': [
+ # Not the pdb, since gyp doesn't know about it
+ '$(OutDir)\\initial\\chrome.dll',
+ ],
+ 'outputs': [
+ '$(OutDir)\\chrome.dll.pdb',
+ ],
+ 'action': ['tools\\build\\win\\hardlink_failsafe.bat',
+ '$(OutDir)\\initial\\chrome.dll.pdb',
+ '$(OutDir)\\chrome.dll.pdb'],
+ 'msvs_cygwin_shell': 0,
+ }
+ ]
+ }]
],
}],
]
@@ -136,7 +157,6 @@
'AdditionalLibraryDirectories': ['$(DXSDK_DIR)/lib/x86'],
'BaseAddress': '0x01c30000',
'ImportLibrary': '$(OutDir)\\lib\\chrome_dll.lib',
- 'ProgramDatabaseFile': '$(OutDir)\\chrome_dll.pdb',
# Set /SUBSYSTEM:WINDOWS for chrome.dll (for consistency).
'SubSystem': '2',
'conditions': [
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698