Issue 1138383007: Switch private WebRTC desktop capture API to use IsOriginSecure() instead of SchemeIsSecure().

Issue 1138383007: Switch private WebRTC desktop capture API to use IsOriginSecure() instead of SchemeIsSecure(). (Closed)

Created:
5 years, 7 months ago by lgarron

Modified:
5 years, 7 months ago

Reviewers:
benwells

CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jiayl

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Switch private WebRTC desktop capture API to use IsOriginSecure() instead of SchemeIsSecure(). This mirrors the change in chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc in https://codereview.chromium.org/1131993005/ BUG=362214 Committed: https://crrev.com/cce355c1f7bca05df3da34b279c67ebba1b20660 Cr-Commit-Position: refs/heads/master@{#330057}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/extensions/api/webrtc_desktop_capture_private/webrtc_desktop_capture_private_api.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

lgarron

benwells@: You were involved with a related CL [1], although not for desktop_capture_api.cc. In that ...

5 years, 7 months ago (2015-05-14 22:23:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138383007/20001

5 years, 7 months ago (2015-05-15 07:27:44 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-15 07:33:28 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cce355c1f7bca05df3da34b279c67ebba1b20660
Cr-Commit-Position: refs/heads/master@{#330057}