Switch //chrome/browser code to use IsOriginSecure() instead of SchemeIsSecure().

Switch //chrome/browser code to use IsOriginSecure() instead of SchemeIsSecure().

We recently introduced SchemeIsCryptographic() and IsOriginSecure(),
which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214
Committed: https://crrev.com/c3efc57462238dc0a5de6e7857f6af6e4459ce6f
Cr-Commit-Position: refs/heads/master@{#329344}

[lgarron, 2015-05-08 23:39:59]

lgarron@chromium.org changed reviewers:
+ bauerb@chromium.org, benwells@chromium.org, felt@chromium.org

[lgarron, 2015-05-08 23:40:00]

Hi! Would you mind looking at the following?
(See the description for semantics.)

bauerb@chromium.org:
chrome/browser/banners/app_banner_manager.cc
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

benwells@chromium.org:
chrome/browser/content_settings/permission_context_uma_util.cc
chrome/browser/ui/content_settings/content_setting_bubble_model.cc

felt@chromium.org:
chrome/browser/ui/content_settings/content_setting_bubble_model.cc (shared owner
with bauerb@)
chrome/browser/ui/website_settings/permission_menu_model.cc

[felt, 2015-05-09 15:14:28]

* Can you wrap your description to 80char (apart from the links)?
* What do you mean by "Fizz code"? Content Settings? Web API restrictions?

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
(right):

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc:116: ?
net::GetHostAndOptionalPort(origin_)
did git cl format do this? the wrapping looks odd

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/permission_menu_model.cc (right):

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/permission_menu_model.cc:61: // Media only
support CONTENT_SETTTING_ALLOW for https.
pls update the comment too

[benwells, 2015-05-10 23:58:26]

c/b/banners and c/b/extensions lgtm

[Bernhard Bauer, 2015-05-11 07:47:11]

bauerb@chromium.org changed reviewers:
+ miguelg@chromium.org

[Bernhard Bauer, 2015-05-11 07:47:13]

content settings LGTM

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/content_sett...
File chrome/browser/content_settings/permission_context_uma_util.cc (right):

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/content_sett...
chrome/browser/content_settings/permission_context_uma_util.cc:84: bool
secure_origin = IsOriginSecure(requesting_origin);
+Miguel

I think this makes sense, but at the very least we should be aware that we are
changing the definition of these histograms now.

[Miguel Garcia, 2015-05-11 08:22:08]

lgtm

Agreed. This makes sense and I don't expect the histograms to change much (who
is using permissions on local files?). I will nevertheless keep an eye on the
histograms once M44 is released.

[lgarron, 2015-05-12 01:53:08]

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
(right):

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc:116: ?
net::GetHostAndOptionalPort(origin_)
On 2015/05/09 15:14:27, felt wrote:
> did git cl format do this? the wrapping looks odd

Yeah, this is the result of `git cl format`.
I don't find the wrapping especially odd, but now that you point it out, I like
the old one better. I've changed it back (starting at the "?" character).

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/permission_menu_model.cc (right):

https://codereview.chromium.org/1131993005/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/permission_menu_model.cc:61: // Media only
support CONTENT_SETTTING_ALLOW for https.
On 2015/05/09 15:14:27, felt wrote:
> pls update the comment too

Done.

[felt, 2015-05-12 01:54:47]

chrome/browser/ui/content_settings/content_setting_bubble_model.cc and
chrome/browser/ui/website_settings/permission_menu_model.cc lgtm

[lgarron, 2015-05-12 01:55:24]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-05-12 01:55:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
miguelg@chromium.org, benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1131993005/#ps20001
(title: "Address felt@'s comments.")

[commit-bot: I haz the power, 2015-05-12 01:58:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131993005/20001

[commit-bot: I haz the power, 2015-05-12 02:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-12 02:09:26]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lgarron, 2015-05-12 02:13:40]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-05-12 02:13:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
miguelg@chromium.org, benwells@chromium.org, felt@chromium.org
Link to the patchset: https://codereview.chromium.org/1131993005/#ps40001
(title: "Rebasin' like it's mah job.")

[lgarron, 2015-05-12 02:13:50]

The CQ bit was unchecked by lgarron@chromium.org

[lgarron, 2015-05-12 02:14:15]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-05-12 02:14:25]

The CQ bit was unchecked by lgarron@chromium.org

[lgarron, 2015-05-12 02:14:30]

Patchset #3 (id:40001) has been deleted

[lgarron, 2015-05-12 02:15:19]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-05-12 02:15:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
miguelg@chromium.org, benwells@chromium.org, felt@chromium.org
Link to the patchset: https://codereview.chromium.org/1131993005/#ps60001
(title: "Rebasin' like it's mah job.")

[commit-bot: I haz the power, 2015-05-12 02:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131993005/60001

[commit-bot: I haz the power, 2015-05-12 02:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-12 02:37:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgarron, 2015-05-12 02:56:09]

Patchset #3 (id:60001) has been deleted

[lgarron, 2015-05-12 02:56:35]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-05-12 02:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
miguelg@chromium.org, benwells@chromium.org, felt@chromium.org
Link to the patchset: https://codereview.chromium.org/1131993005/#ps80001
(title: "Rebasin' like it's mah job.")

[commit-bot: I haz the power, 2015-05-12 02:57:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131993005/80001

[commit-bot: I haz the power, 2015-05-12 03:49:47]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-05-12 03:50:39]

Patchset 3 (id:??) landed as
https://crrev.com/c3efc57462238dc0a5de6e7857f6af6e4459ce6f
Cr-Commit-Position: refs/heads/master@{#329344}