Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 1138353003: [Password manager tests automation] Fixes buzzfeed test. (Closed)

Created:
5 years, 7 months ago by melandory
Modified:
5 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager tests automation] Fixed buzzfeed. Fixes buzzfeed by introducing password_not_auto parameter. BUG=369521 R=vabr@chromium.org Committed: https://crrev.com/f1be3c264853e564c69053f580d14fabfbfea62b Cr-Commit-Position: refs/heads/master@{#330502}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M components/test/data/password_manager/automated_tests/tests.py View 1 chunk +3 lines, -1 line 0 comments Download
M components/test/data/password_manager/automated_tests/websitetest.py View 1 3 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
melandory
Hi Vaclav, review this CL, please. Thanks in advance.
5 years, 7 months ago (2015-05-18 14:31:47 UTC) #1
vabr (Chromium)
Thanks, Tanja. I left some comments, please have a look. Cheers, Vaclav https://codereview.chromium.org/1138353003/diff/1/components/test/data/password_manager/automated_tests/run_tests.py File components/test/data/password_manager/automated_tests/run_tests.py ...
5 years, 7 months ago (2015-05-18 16:13:34 UTC) #2
melandory
https://codereview.chromium.org/1138353003/diff/1/components/test/data/password_manager/automated_tests/run_tests.py File components/test/data/password_manager/automated_tests/run_tests.py (right): https://codereview.chromium.org/1138353003/diff/1/components/test/data/password_manager/automated_tests/run_tests.py#newcode115 components/test/data/password_manager/automated_tests/run_tests.py:115: attempts = 1 On 2015/05/18 16:13:34, vabr (Chromium) wrote: ...
5 years, 7 months ago (2015-05-19 08:06:34 UTC) #4
vabr (Chromium)
LGTM, thanks! Vaclav
5 years, 7 months ago (2015-05-19 09:01:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138353003/40001
5 years, 7 months ago (2015-05-19 09:09:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-19 10:36:55 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 10:37:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1be3c264853e564c69053f580d14fabfbfea62b
Cr-Commit-Position: refs/heads/master@{#330502}

Powered by Google App Engine
This is Rietveld 408576698